From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, amirv@mellanox.com,
jackm@dev.mellanox.co.il, hadarh@mellanox.com
Subject: Re: [PATCH net 3/5] net/mlx4_en: Remove ethtool flow steering rules before releasing QPs
Date: Thu, 21 Mar 2013 21:28:08 +0300 [thread overview]
Message-ID: <514B5138.4040106@cogentembedded.com> (raw)
In-Reply-To: <1363881355-21137-4-git-send-email-ogerlitz@mellanox.com>
Hello.
On 03/21/2013 06:55 PM, Or Gerlitz wrote:
> From: Hadar Hen Zion <hadarh@mellanox.com>
>
> Fix the ethtool flow steering rules cleanup to be carried out before
> releasing the RX QPs.
>
> Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 22 +++++++++++-----------
> 1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index 995d4b6..f278b10 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -1637,6 +1637,17 @@ void mlx4_en_stop_port(struct net_device *dev, int detach)
> /* Flush multicast filter */
> mlx4_SET_MCAST_FLTR(mdev->dev, priv->port, 0, 1, MLX4_MCAST_CONFIG);
>
> + /* Remove flow steering rules for the port*/
Could you add a space before */, despite it was missing before?
WBR, Sergei
next prev parent reply other threads:[~2013-03-21 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 15:55 [PATCH net 0/5] Mellanox Core and Ethernet driver fixes 2013-03-21 Or Gerlitz
2013-03-21 15:55 ` [PATCH net 1/5] net/mlx4_core: Fix wrong mask applied on EQ numbers in the wrapper Or Gerlitz
2013-03-21 15:55 ` [PATCH net 2/5] net/mlx4_core: Fix wrong order of flow steering resources removal Or Gerlitz
2013-03-21 15:55 ` [PATCH net 3/5] net/mlx4_en: Remove ethtool flow steering rules before releasing QPs Or Gerlitz
2013-03-21 18:28 ` Sergei Shtylyov [this message]
2013-03-21 15:55 ` [PATCH net 4/5] net/mlx4_core: Always use 64 bit resource ID when doing lookup Or Gerlitz
2013-03-21 15:55 ` [PATCH net 5/5] net/mlx4_core: Disallow releasing VF QPs which have steering rules Or Gerlitz
2013-03-21 16:05 ` [PATCH net 0/5] Mellanox Core and Ethernet driver fixes 2013-03-21 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B5138.4040106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).