From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: <xen-devel@lists.xen.org>, <netdev@vger.kernel.org>,
<annie.li@oracle.com>, <david.vrabel@citrix.com>,
<ian.campbell@citrix.com>, <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [PATCH 3/6] xen-netfront: frags -> slots in xennet_get_responses
Date: Mon, 25 Mar 2013 14:25:06 +0000 [thread overview]
Message-ID: <51505E42.3050403@citrix.com> (raw)
In-Reply-To: <1364209702-12437-4-git-send-email-wei.liu2@citrix.com>
On 25/03/13 11:08, Wei Liu wrote:
> This function is in fact counting the ring slots required for responses.
> Separate the concepts of ring slots and skb frags make the code clearer, as
> now netfront and netback can have different MAX_SKB_FRAGS, slot and frag are
> not mapped 1:1 any more.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Makes sense.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2013-03-25 14:25 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:08 [PATCH 0/6 V2] Bundle fixes for Xen netfront / netback Wei Liu
2013-03-25 11:08 ` [PATCH 1/6] xen-netfront: remove unused variable `extra' Wei Liu
2013-03-25 14:21 ` [Xen-devel] " David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 2/6] xen-netfront: reduce gso_max_size to account for ethernet header Wei Liu
2013-03-25 14:23 ` [Xen-devel] " David Vrabel
2013-03-25 14:39 ` Jan Beulich
2013-03-25 15:50 ` Sergei Shtylyov
2013-03-25 16:18 ` David Miller
2013-03-25 16:54 ` Eric Dumazet
2013-03-25 16:59 ` David Miller
2013-03-25 17:24 ` Eric Dumazet
2013-03-25 20:49 ` Ben Hutchings
2013-03-25 18:32 ` Wei Liu
2013-03-25 18:39 ` David Miller
2013-03-25 16:56 ` Konrad Rzeszutek Wilk
2013-03-25 11:08 ` [PATCH 3/6] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-03-25 14:25 ` David Vrabel [this message]
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 4/6] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 5/6] xen-netback: coalesce slots before copying Wei Liu
2013-03-25 15:13 ` David Vrabel
2013-03-25 15:47 ` [Xen-devel] " Wei Liu
2013-03-25 16:34 ` David Vrabel
2013-03-25 16:58 ` Wei Liu
2013-03-25 17:06 ` [Xen-devel] " Wei Liu
2013-03-25 18:29 ` David Vrabel
2013-03-25 19:09 ` Wei Liu
2013-03-26 9:16 ` Paul Durrant
2013-03-26 9:51 ` Wei Liu
2013-03-26 11:00 ` James Harper
2013-03-26 11:24 ` Paul Durrant
2013-03-26 11:29 ` James Harper
2013-03-26 11:38 ` Paul Durrant
2013-03-26 11:27 ` David Laight
2013-03-26 10:52 ` James Harper
2013-03-26 11:06 ` David Vrabel
2013-03-26 11:15 ` James Harper
2013-03-26 11:13 ` David Vrabel
2013-03-26 11:29 ` Wei Liu
2013-03-25 16:20 ` David Miller
2013-03-25 16:57 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-04-09 15:10 ` Ian Campbell
2013-03-26 18:02 ` David Vrabel
2013-03-25 11:08 ` [PATCH 6/6] xen-netback: don't disconnect frontend when seeing oversize frame Wei Liu
2013-03-25 11:47 ` David Vrabel
2013-03-25 12:00 ` Wei Liu
2013-03-25 12:53 ` [Xen-devel] " Jan Beulich
2013-03-25 13:52 ` Wei Liu
2013-03-25 16:21 ` David Miller
2013-03-25 16:58 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-27 10:03 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51505E42.3050403@citrix.com \
--to=david.vrabel@citrix.com \
--cc=annie.li@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).