From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 1/1]core:Change a wrong explain about dev_get_by_name Date: Mon, 25 Mar 2013 19:44:10 +0400 Message-ID: <515070CA.2010701@cogentembedded.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Alexey Kuznetsov , davem@davemloft.net, Eric Dumazet , Ben Hutchings , Linus Torvalds To: tingwei liu Return-path: Received: from mail-la0-f45.google.com ([209.85.215.45]:49854 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758520Ab3CYPpJ (ORCPT ); Mon, 25 Mar 2013 11:45:09 -0400 Received: by mail-la0-f45.google.com with SMTP id er20so11702897lab.18 for ; Mon, 25 Mar 2013 08:45:08 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 25-03-2013 8:10, tingwei liu wrote: > From: Tingwei Liu > Date: Mon, 25 Mar 2013 11:09:59 +0800 > Subject: [PATCH] Change a wrong explain about dev_get_by_name > a long time ago by the commit. Did you mean "before the commit"? > commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 > Author: Linus Torvalds > Date: Sat Apr 16 15:20:36 2005 -0700 > Linux-2.6.12-rc2 > Initial git repository build. I'm not bothering with the full history, > even though we have it. We can create a separate "historical" git > archive of that later if we want to, and in the meantime it's about > 3.2GB when imported into git - space that would just make the early > git days unnecessarily complicated, when we don't have a lot of good > infrastructure for it. > Let it rip! > When function "list_netdevice" get write lock "dev_base_lock" only > disable soft interrupt. So dev_get_by_name get read lock > "dev_base_lock", can not called on interrupt context. > Signed-off-by: Tingwei Liu > --- > Changes from v1: > - add change log > - add the commnet > > net/core/dev.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index d540ced..20c5c7c 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -700,10 +700,10 @@ EXPORT_SYMBOL(dev_get_by_name_rcu); > * @name: name to find > * > * Find an interface by name. This can be called from any > - * context and does its own locking. The returned handle has > - * the usage count incremented and the caller must use dev_put() to > - * release it when it is no longer needed. %NULL is returned if no > - * matching device is found. > + * context except hard irq context and does its own locking. > + * The returned handle has the usage count incremented and the > + * caller must use dev_put() to release it when it is no longer > + * needed. %NULL is returned if no matching device is found. It seems your patch has all the tabs replaced by spaces. WBR, Sergei