netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Haley <brian.haley@hp.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, "Eric Dumazet" <edumazet@google.com>,
	"Mike Dalton" <mwdalton@google.com>
Subject: Re: [PATCH] ipv6: fix raw socket checksum for udplite
Date: Tue, 26 Mar 2013 22:30:25 -0400	[thread overview]
Message-ID: <515259C1.20204@hp.com> (raw)
In-Reply-To: <1364337095-19663-1-git-send-email-zenczykowski@gmail.com>

On 03/26/2013 06:31 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> Commit d3a1be9cba86 from Brian Haley in Nov 2006
> "[IPv6]: Only modify checksum for UDP" forgot about
> UDPLITE.

I'm not sure I'd say I "forgot about" it, UDPLITE support didn't exist in Linux
until three+ weeks after that commit.

commit d3a1be9cba86c4385a5fe46673bbb4730551f454
Author: Brian Haley <brian.haley@hp.com>
Date:   Fri Nov 10 14:54:51 2006 -0800

    [IPv6]: Only modify checksum for UDP

commit ba4e58eca8aa9473b44fdfd312f26c4a2e7798b3
Author: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date:   Mon Nov 27 11:10:57 2006 -0800

    [NET]: Supporting UDP-Lite (RFC 3828) in Linux

I see no reason your patch isn't correct though.

Acked-by: Brian Haley <brian.haley@hp.com>

-Brian

  reply	other threads:[~2013-03-27  2:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 22:31 [PATCH] ipv6: fix raw socket checksum for udplite Maciej Żenczykowski
2013-03-27  2:30 ` Brian Haley [this message]
2013-03-27  4:55   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515259C1.20204@hp.com \
    --to=brian.haley@hp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=maze@google.com \
    --cc=mwdalton@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).