[PATCH net-next] audit: pass int* to nlmsg_next

[PATCH net-next] audit: pass int* to nlmsg_next

[Alexandru Copot]

Commit 941912133025926307c7a65b203fa38403b1063a replaced the macros
NLMSG_NEXT with calls to nlmsg_next which produces this warning:

kernel/audit.c: In function ‘audit_receive_skb’:
kernel/audit.c:928:3: warning: passing argument 2 of ‘nlmsg_next’ makes pointer from integer without a cast
In file included from include/net/rtnetlink.h:5:0,
                 from include/net/neighbour.h:28,
                 from include/net/dst.h:17,
                 from include/net/sock.h:68,
                 from kernel/audit.c:55:
include/net/netlink.h:359:1: note: expected ‘int *’ but argument is of type ‘int’

Fix this by sending the intended pointer.

Signed-off-by: Alexandru Copot <alex.mihai.c@gmail.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 4dbb047..488f85f 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -925,7 +925,7 @@ static void audit_receive_skb(struct sk_buff *skb)
 		if (err || (nlh->nlmsg_flags & NLM_F_ACK))
 			netlink_ack(skb, nlh, err);
 
-		nlh = nlmsg_next(nlh, len);
+		nlh = nlmsg_next(nlh, &len);
 	}
 }
 
-- 
1.8.2

Re: [PATCH net-next] audit: pass int* to nlmsg_next

[David Miller]

From: Alexandru Copot <alex.mihai.c@gmail.com>
Date: Thu, 28 Mar 2013 23:31:29 +0200

> Commit 941912133025926307c7a65b203fa38403b1063a replaced the macros
> NLMSG_NEXT with calls to nlmsg_next which produces this warning:
> 
> kernel/audit.c: In function ‘audit_receive_skb’:
> kernel/audit.c:928:3: warning: passing argument 2 of ‘nlmsg_next’ makes pointer from integer without a cast
> In file included from include/net/rtnetlink.h:5:0,
>                  from include/net/neighbour.h:28,
>                  from include/net/dst.h:17,
>                  from include/net/sock.h:68,
>                  from kernel/audit.c:55:
> include/net/netlink.h:359:1: note: expected ‘int *’ but argument is of type ‘int’
> 
> Fix this by sending the intended pointer.
> 
> Signed-off-by: Alexandru Copot <alex.mihai.c@gmail.com>

Applied, thanks.

Re: [PATCH net-next] audit: pass int* to nlmsg_next

[Sergei Shtylyov]

Hello.

On 29-03-2013 1:31, Alexandru Copot wrote:

> Commit 941912133025926307c7a65b203fa38403b1063a

    Please also specify the summary line of that commit in parens (or however 
you like).
    With that, you can add my:

Acked-by: Sergei Shtylyov <segei.shtylyov@cogentembedded.com>

> replaced the macros
> NLMSG_NEXT with calls to nlmsg_next which produces this warning:

> kernel/audit.c: In function ‘audit_receive_skb’:
> kernel/audit.c:928:3: warning: passing argument 2 of ‘nlmsg_next’ makes pointer from integer without a cast
> In file included from include/net/rtnetlink.h:5:0,
>                   from include/net/neighbour.h:28,
>                   from include/net/dst.h:17,
>                   from include/net/sock.h:68,
>                   from kernel/audit.c:55:
> include/net/netlink.h:359:1: note: expected ‘int *’ but argument is of type ‘int’

> Fix this by sending the intended pointer.

> Signed-off-by: Alexandru Copot <alex.mihai.c@gmail.com>

WBR, Sergei