From: Daniel Borkmann <dborkman@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Eric Leblond <eric@regit.org>,
Victor Julien <victor@inliniac.net>
Subject: Re: [PATCH net-next] doc: packet: add minimal TPACKET_V3 example code
Date: Fri, 29 Mar 2013 16:50:02 +0100 [thread overview]
Message-ID: <5155B82A.2050701@redhat.com> (raw)
In-Reply-To: <1364571737.5113.25.camel@edumazet-glaptop>
On 03/29/2013 04:42 PM, Eric Dumazet wrote:
> On Fri, 2013-03-29 at 16:36 +0100, Daniel Borkmann wrote:
>> Lost in space for a long time, but it finally came back to us from
>> some ancient code tombs. This patch adds a minimal runnable example
>> of Linux' packet mmap(2) from Chetan Loke's TPACKET_V3. Special
>> thanks to David S. Miller, and also Eric Leblond and Victor Julien!
>>
>> Cc: Eric Leblond <eric@regit.org>
>> Cc: Victor Julien <victor@inliniac.net>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> ---
>> Documentation/networking/packet_mmap.txt | 327 +++++++++++++++++++++++++++++++
>> 1 file changed, 327 insertions(+)
>
> tools/testing/selftests/net seems a better place to get another
> program ?
Hm, well. Actually, it should serve as nothing more than a code example
that does nothing useful except shows how to use it. Just like the packet
fanout example in the same file. It should just provide a starting point
for people to grab it and build something bigger out of it.
In a follow-up patch I could add a test case, /specificly designed/ to
do basic sanity checks. I think if people are looking for that, they
might not be starting under tools/testing/selftests/net, no?
next prev parent reply other threads:[~2013-03-29 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 15:36 [PATCH net-next] doc: packet: add minimal TPACKET_V3 example code Daniel Borkmann
2013-03-29 15:42 ` Eric Dumazet
2013-03-29 15:50 ` Daniel Borkmann [this message]
2013-03-30 21:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155B82A.2050701@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=eric@regit.org \
--cc=netdev@vger.kernel.org \
--cc=victor@inliniac.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).