* [v3.8, v3.9] [Regression] brcmsmac: move PHY functions
@ 2013-03-29 19:52 Joseph Salisbury
2013-04-01 14:42 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Joseph Salisbury @ 2013-03-29 19:52 UTC (permalink / raw)
To: phaber
Cc: arend, pieterpg, meuleman, phaber, linville, LKML, brudley,
frankyl, linux-wireless, brcm80211-dev-list, netdev
Hi Piotr,
A bug was opened against the Ubuntu kernel[0]. After a kernel
bisect, it was found that reverting the following commit resolved
this bug:
commit b83576341664957978e125f5f5db2f15496980b1
Author: Piotr Haber <phaber@broadcom.com>
Date: Wed Nov 28 21:44:09 2012 +0100
brcmsmac: move PHY functions
The regression was introduced as of v3.8-rc1. The regression still
exists in v3.9-rc4.
I see that you are the author of this patch, so I wanted to run this
by you. I was thinking of requesting a revert for v3.9, but I
wanted to get your feedback first.
Thanks,
Joe
[0] http://pad.lv/1131914
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [v3.8, v3.9] [Regression] brcmsmac: move PHY functions 2013-03-29 19:52 [v3.8, v3.9] [Regression] brcmsmac: move PHY functions Joseph Salisbury @ 2013-04-01 14:42 ` John W. Linville 2013-04-01 15:18 ` Joseph Salisbury 0 siblings, 1 reply; 5+ messages in thread From: John W. Linville @ 2013-04-01 14:42 UTC (permalink / raw) To: Joseph Salisbury Cc: phaber, arend, pieterpg, meuleman, LKML, brudley, frankyl, linux-wireless, brcm80211-dev-list, netdev On Fri, Mar 29, 2013 at 03:52:39PM -0400, Joseph Salisbury wrote: > Hi Piotr, > > A bug was opened against the Ubuntu kernel[0]. After a kernel > bisect, it was found that reverting the following commit resolved > this bug: > > commit b83576341664957978e125f5f5db2f15496980b1 > Author: Piotr Haber <phaber@broadcom.com> > Date: Wed Nov 28 21:44:09 2012 +0100 > > brcmsmac: move PHY functions > > The regression was introduced as of v3.8-rc1. The regression still > exists in v3.9-rc4. > > I see that you are the author of this patch, so I wanted to run this > by you. I was thinking of requesting a revert for v3.9, but I > wanted to get your feedback first. > > > Thanks, > > Joe > > [0] http://pad.lv/1131914 I recently reverted b6fc28a1, which is the follow-on to that patch. The revert is _not_ in 3.9-rc5. Could you try reverting that patch instead? Does that fix the issue for you? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v3.8, v3.9] [Regression] brcmsmac: move PHY functions 2013-04-01 14:42 ` John W. Linville @ 2013-04-01 15:18 ` Joseph Salisbury 2013-04-02 9:02 ` Piotr Haber 0 siblings, 1 reply; 5+ messages in thread From: Joseph Salisbury @ 2013-04-01 15:18 UTC (permalink / raw) To: John W. Linville Cc: phaber, arend, pieterpg, meuleman, LKML, brudley, frankyl, linux-wireless, brcm80211-dev-list, netdev On 04/01/2013 10:42 AM, John W. Linville wrote: > On Fri, Mar 29, 2013 at 03:52:39PM -0400, Joseph Salisbury wrote: >> Hi Piotr, >> >> A bug was opened against the Ubuntu kernel[0]. After a kernel >> bisect, it was found that reverting the following commit resolved >> this bug: >> >> commit b83576341664957978e125f5f5db2f15496980b1 >> Author: Piotr Haber <phaber@broadcom.com> >> Date: Wed Nov 28 21:44:09 2012 +0100 >> >> brcmsmac: move PHY functions >> >> The regression was introduced as of v3.8-rc1. The regression still >> exists in v3.9-rc4. >> >> I see that you are the author of this patch, so I wanted to run this >> by you. I was thinking of requesting a revert for v3.9, but I >> wanted to get your feedback first. >> >> >> Thanks, >> >> Joe >> >> [0] http://pad.lv/1131914 > I recently reverted b6fc28a1, which is the follow-on to that patch. > The revert is _not_ in 3.9-rc5. > > Could you try reverting that patch instead? Does that fix the issue > for you? > > John Hi John, Thanks for the response. Yes, reverting commit b6fc28a1 does resolve this bug. That is the appropriate fix for this issue. Thanks for the assistance. Thanks, Joe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v3.8, v3.9] [Regression] brcmsmac: move PHY functions 2013-04-01 15:18 ` Joseph Salisbury @ 2013-04-02 9:02 ` Piotr Haber 2013-04-03 15:28 ` Joseph Salisbury 0 siblings, 1 reply; 5+ messages in thread From: Piotr Haber @ 2013-04-02 9:02 UTC (permalink / raw) To: Joseph Salisbury Cc: John W. Linville, arend, pieterpg, meuleman, LKML, brudley, frankyl, linux-wireless, brcm80211-dev-list, netdev On 04/01/13 17:18, Joseph Salisbury wrote: > On 04/01/2013 10:42 AM, John W. Linville wrote: >> On Fri, Mar 29, 2013 at 03:52:39PM -0400, Joseph Salisbury wrote: >>> Hi Piotr, >>> >>> A bug was opened against the Ubuntu kernel[0]. After a kernel >>> bisect, it was found that reverting the following commit resolved >>> this bug: >>> >>> commit b83576341664957978e125f5f5db2f15496980b1 >>> Author: Piotr Haber <phaber@broadcom.com> >>> Date: Wed Nov 28 21:44:09 2012 +0100 >>> >>> brcmsmac: move PHY functions >>> >>> The regression was introduced as of v3.8-rc1. The regression still >>> exists in v3.9-rc4. >>> >>> I see that you are the author of this patch, so I wanted to run this >>> by you. I was thinking of requesting a revert for v3.9, but I >>> wanted to get your feedback first. >>> >>> >>> Thanks, >>> >>> Joe >>> >>> [0] http://pad.lv/1131914 >> I recently reverted b6fc28a1, which is the follow-on to that patch. >> The revert is _not_ in 3.9-rc5. >> >> Could you try reverting that patch instead? Does that fix the issue >> for you? >> >> John > > Hi John, > > Thanks for the response. > > Yes, reverting commit b6fc28a1 does resolve this bug. That is the appropriate fix for this issue. > Thanks for the assistance. > > Thanks, > > Joe > > > > Hi Joe, could you elaborate a little bit on your failure scenario? In bug report you say it happens after suspend/resume, are there any other scenarios you see this behaviour? (like disassociation/association without suspend) Also you mention it comes back after some time - what is the time needed? We had reports of problems on 4313 with this patch (that's why the revert was done) but so far i assumed it was a total breakdown, in your case this seem like a transient issue. One more thing, could you provide info about your hardware by sending me contents of: <debugfs_mount>/brcmsmac/bcma0:0/hardware Kind regards Piotr ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v3.8, v3.9] [Regression] brcmsmac: move PHY functions 2013-04-02 9:02 ` Piotr Haber @ 2013-04-03 15:28 ` Joseph Salisbury 0 siblings, 0 replies; 5+ messages in thread From: Joseph Salisbury @ 2013-04-03 15:28 UTC (permalink / raw) To: Piotr Haber Cc: John W. Linville, arend, pieterpg, meuleman, LKML, brudley, frankyl, linux-wireless, brcm80211-dev-list, netdev On 04/02/2013 05:02 AM, Piotr Haber wrote: > On 04/01/13 17:18, Joseph Salisbury wrote: >> On 04/01/2013 10:42 AM, John W. Linville wrote: >>> On Fri, Mar 29, 2013 at 03:52:39PM -0400, Joseph Salisbury wrote: >>>> Hi Piotr, >>>> >>>> A bug was opened against the Ubuntu kernel[0]. After a kernel >>>> bisect, it was found that reverting the following commit resolved >>>> this bug: >>>> >>>> commit b83576341664957978e125f5f5db2f15496980b1 >>>> Author: Piotr Haber <phaber@broadcom.com> >>>> Date: Wed Nov 28 21:44:09 2012 +0100 >>>> >>>> brcmsmac: move PHY functions >>>> >>>> The regression was introduced as of v3.8-rc1. The regression still >>>> exists in v3.9-rc4. >>>> >>>> I see that you are the author of this patch, so I wanted to run this >>>> by you. I was thinking of requesting a revert for v3.9, but I >>>> wanted to get your feedback first. >>>> >>>> >>>> Thanks, >>>> >>>> Joe >>>> >>>> [0] http://pad.lv/1131914 >>> I recently reverted b6fc28a1, which is the follow-on to that patch. >>> The revert is _not_ in 3.9-rc5. >>> >>> Could you try reverting that patch instead? Does that fix the issue >>> for you? >>> >>> John >> Hi John, >> >> Thanks for the response. >> >> Yes, reverting commit b6fc28a1 does resolve this bug. That is the appropriate fix for this issue. >> Thanks for the assistance. >> >> Thanks, >> >> Joe >> >> >> >> > Hi Joe, > could you elaborate a little bit on your failure scenario? > In bug report you say it happens after suspend/resume, are there any other scenarios you see this > behaviour? (like disassociation/association without suspend) > Also you mention it comes back after some time - what is the time needed? > We had reports of problems on 4313 with this patch (that's why the revert was done) but so far i > assumed it was a total breakdown, in your case this seem like a transient issue. This only happens after a suspend/resume cycle. I haven't seen the issue happen with disassociation/association without suspend. After suspend, the connection will re-establish after about 15 minutes or so. > > One more thing, could you provide info about your hardware by sending me contents of: > <debugfs_mount>/brcmsmac/bcma0:0/hardware board vendor: 144f board type: 7179 board revision: 1408 board flags: 8402a01 board flags2: 880 firmware revision: 262032c > > Kind regards > Piotr > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-03 15:28 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-29 19:52 [v3.8, v3.9] [Regression] brcmsmac: move PHY functions Joseph Salisbury 2013-04-01 14:42 ` John W. Linville 2013-04-01 15:18 ` Joseph Salisbury 2013-04-02 9:02 ` Piotr Haber 2013-04-03 15:28 ` Joseph Salisbury
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).