* [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'
@ 2013-04-01 1:52 Chen Gang
2013-04-01 14:04 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2013-04-01 1:52 UTC (permalink / raw)
To: isdn, Jiri Slaby, 'Jiri Kosina', tilman
Cc: David Miller, netdev@vger.kernel.org >> netdev
delete useless break statements.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/isdn/divert/isdn_divert.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c
index db432e6..76d505e 100644
--- a/drivers/isdn/divert/isdn_divert.c
+++ b/drivers/isdn/divert/isdn_divert.c
@@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
switch (dv->rule.action) {
case DEFLECT_IGNORE:
return (0);
- break;
case DEFLECT_ALERT:
case DEFLECT_PROCEED:
@@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
default:
return (0); /* ignore call */
- break;
} /* switch action */
break;
} /* scan_table */
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'
2013-04-01 1:52 [PATCH] drivers/isdn/divert: beautify code, delete useless 'break' Chen Gang
@ 2013-04-01 14:04 ` Sergei Shtylyov
2013-04-02 0:44 ` Chen Gang
2013-04-02 1:37 ` [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments Chen Gang
0 siblings, 2 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-04-01 14:04 UTC (permalink / raw)
To: Chen Gang
Cc: isdn, Jiri Slaby, 'Jiri Kosina', tilman, David Miller,
netdev@vger.kernel.org >> netdev
Hello.
On 01-04-2013 5:52, Chen Gang wrote:
> delete useless break statements.
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/isdn/divert/isdn_divert.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
> diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c
> index db432e6..76d505e 100644
> --- a/drivers/isdn/divert/isdn_divert.c
> +++ b/drivers/isdn/divert/isdn_divert.c
> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
> switch (dv->rule.action) {
> case DEFLECT_IGNORE:
> return (0);
> - break;
>
> case DEFLECT_ALERT:
> case DEFLECT_PROCEED:
> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>
> default:
> return (0); /* ignore call */
> - break;
You could have removed stupid () around 0, while at it.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'
2013-04-01 14:04 ` Sergei Shtylyov
@ 2013-04-02 0:44 ` Chen Gang
2013-04-02 1:37 ` [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments Chen Gang
1 sibling, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-04-02 0:44 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: isdn, Jiri Slaby, 'Jiri Kosina', tilman, David Miller,
netdev@vger.kernel.org >> netdev
On 2013年04月01日 22:04, Sergei Shtylyov wrote:
>
>> diff --git a/drivers/isdn/divert/isdn_divert.c
>> b/drivers/isdn/divert/isdn_divert.c
>> index db432e6..76d505e 100644
>> --- a/drivers/isdn/divert/isdn_divert.c
>> +++ b/drivers/isdn/divert/isdn_divert.c
>> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>> switch (dv->rule.action) {
>> case DEFLECT_IGNORE:
>> return (0);
>> - break;
>>
>> case DEFLECT_ALERT:
>> case DEFLECT_PROCEED:
>> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>>
>> default:
>> return (0); /* ignore call */
>> - break;
>
> You could have removed stupid () around 0, while at it.
oh, really, I should do it.
I will send patch v2 for it
thanks.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments.
2013-04-01 14:04 ` Sergei Shtylyov
2013-04-02 0:44 ` Chen Gang
@ 2013-04-02 1:37 ` Chen Gang
2013-04-02 18:31 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Chen Gang @ 2013-04-02 1:37 UTC (permalink / raw)
To: Sergei Shtylyov, isdn, Jiri Slaby, 'Jiri Kosina', tilman
Cc: David Miller, netdev@vger.kernel.org >> netdev
delete useless 'break' after 'return'.
let 'return 0' instead of 'return (0)'
also give a comment for 'break' to let readers notice it.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/isdn/divert/isdn_divert.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c
index db432e6..50749a7 100644
--- a/drivers/isdn/divert/isdn_divert.c
+++ b/drivers/isdn/divert/isdn_divert.c
@@ -441,8 +441,7 @@ static int isdn_divert_icall(isdn_ctrl *ic)
switch (dv->rule.action) {
case DEFLECT_IGNORE:
- return (0);
- break;
+ return 0;
case DEFLECT_ALERT:
case DEFLECT_PROCEED:
@@ -510,10 +509,9 @@ static int isdn_divert_icall(isdn_ctrl *ic)
break;
default:
- return (0); /* ignore call */
- break;
+ return 0; /* ignore call */
} /* switch action */
- break;
+ break; /* will break the 'for' looping */
} /* scan_table */
if (cs) {
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments.
2013-04-02 1:37 ` [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments Chen Gang
@ 2013-04-02 18:31 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-04-02 18:31 UTC (permalink / raw)
To: gang.chen; +Cc: sergei.shtylyov, isdn, jslaby, trivial, tilman, netdev
From: Chen Gang <gang.chen@asianux.com>
Date: Tue, 02 Apr 2013 09:37:56 +0800
>
> delete useless 'break' after 'return'.
> let 'return 0' instead of 'return (0)'
> also give a comment for 'break' to let readers notice it.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-02 18:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 1:52 [PATCH] drivers/isdn/divert: beautify code, delete useless 'break' Chen Gang
2013-04-01 14:04 ` Sergei Shtylyov
2013-04-02 0:44 ` Chen Gang
2013-04-02 1:37 ` [PATCH] ISDN:divert: beautify code: useless 'break', 'return (0)', additional comments Chen Gang
2013-04-02 18:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).