From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net,
"Akeem G. Abodunrin" <akeem.g.abodunrin@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 07/13] igb: random code and comments fix
Date: Thu, 04 Apr 2013 18:22:18 +0400 [thread overview]
Message-ID: <515D8C9A.8030606@cogentembedded.com> (raw)
In-Reply-To: <1365075480-20183-8-git-send-email-jeffrey.t.kirsher@intel.com>
Hello.
On 04-04-2013 15:37, Jeff Kirsher wrote:
> From: "Akeem G. Abodunrin" <akeem.g.abodunrin@intel.com>
> This patch fixes code and comments as identified in the driver.
It seems you are doing 3 different things in 3 different files in this
patch... it would be better to split it up.
> Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[...]
> diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c
> index a5c7200..5d407f4 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_mac.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c
> @@ -1007,9 +1007,9 @@ s32 igb_config_fc_after_link_up(struct e1000_hw *hw)
> * be asked to delay transmission of packets than asking
> * our link partner to pause transmission of frames.
> */
> - else if ((hw->fc.requested_mode == e1000_fc_none ||
> - hw->fc.requested_mode == e1000_fc_tx_pause) ||
> - hw->fc.strict_ieee) {
> + else if ((hw->fc.requested_mode == e1000_fc_none) ||
> + (hw->fc.requested_mode == e1000_fc_tx_pause) ||
> + (hw->fc.strict_ieee)) {
The code was alright bnefore this change, so this isn't really a fix at
all. Aside of that, () around == are not needed, and yet less around
'hw->fc.strict_ieee'.
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index fb162ef..8752f4f 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -3859,9 +3859,8 @@ static bool igb_thermal_sensor_event(struct e1000_hw *hw, u32 event)
> ctrl_ext = rd32(E1000_CTRL_EXT);
>
> if ((hw->phy.media_type == e1000_media_type_copper) &&
> - !(ctrl_ext & E1000_CTRL_EXT_LINK_MODE_SGMII)) {
> + !(ctrl_ext & E1000_CTRL_EXT_LINK_MODE_SGMII))
> ret = !!(thstat & event);
> - }
This was checkpatch.pl's message right?
WBR, Sergei
next prev parent reply other threads:[~2013-04-04 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 11:37 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-04-04 11:37 ` [net-next 01/13] ixgbe: Mask off check of frag_off as we only want fragment offset Jeff Kirsher
2013-04-04 11:37 ` [net-next 02/13] ixgbe: don't do arithmetic operations on bitmasks Jeff Kirsher
2013-04-04 11:37 ` [net-next 03/13] ixgbe: Drop check for PAGE_SIZE from ixgbe_xmit_frame_ring Jeff Kirsher
2013-04-04 11:37 ` [net-next 04/13] igb: Support for 100base-fx SFP Jeff Kirsher
2013-04-04 11:37 ` [net-next 05/13] igb: Support to read and export SFF-8472/8079 data Jeff Kirsher
2013-04-04 19:07 ` Ben Hutchings
2013-04-04 22:17 ` Abodunrin, Akeem G
2013-04-04 11:37 ` [net-next 06/13] igb: Implement support to power sfp cage and turn on I2C Jeff Kirsher
2013-04-04 11:37 ` [net-next 07/13] igb: random code and comments fix Jeff Kirsher
2013-04-04 14:22 ` Sergei Shtylyov [this message]
2013-04-04 11:37 ` [net-next 08/13] igb: Mask off check of frag_off as we only want fragment offset Jeff Kirsher
2013-04-04 11:37 ` [net-next 09/13] igb: Pull adapter out of main path in igb_xmit_frame_ring Jeff Kirsher
2013-04-04 14:15 ` Sergei Shtylyov
2013-04-04 11:37 ` [net-next 10/13] igb: Use rx/tx_itr_setting when setting up initial value of itr Jeff Kirsher
2013-04-04 11:37 ` [net-next 11/13] igb: Fix sparse warnings on function pointers Jeff Kirsher
2013-04-04 11:37 ` [net-next 12/13] igb: Fix code comments and whitespace Jeff Kirsher
2013-04-04 11:38 ` [net-next 13/13] igb: Enable EEE LP advertisement Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D8C9A.8030606@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=akeem.g.abodunrin@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).