From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C91DC41518 for ; Thu, 24 Jan 2019 16:41:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E278218A2 for ; Thu, 24 Jan 2019 16:41:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xg4vA+Jy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728587AbfAXQlV (ORCPT ); Thu, 24 Jan 2019 11:41:21 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42351 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727573AbfAXQlV (ORCPT ); Thu, 24 Jan 2019 11:41:21 -0500 Received: by mail-pl1-f196.google.com with SMTP id y1so3128333plp.9 for ; Thu, 24 Jan 2019 08:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Brw9s3yqqyX/Ik9f0mLhoLX1RMI4X/CZLtpJzeCpuyM=; b=Xg4vA+Jyg4CBPAk41e50WqsIlqEz4bwfJFxrCvl6ycLF2OCNZRXUSAbjOGyUhinwEr RKwa+M32xCREnUAsGR4sNXn54DbHv8bPpIWqoHrR6d+ylDpIUajKNyHMmzrMuspuHaLA 9Y3kNDAeL68b2X38+1b+NK5UJ+JTZg4FN2COzD7dPXVA706Fpy6hmquHx5TCYCJd/XEx jd3JeAXGdLlFRuqTul7zVoF6B9nle5wY1x5zm2rn7Xiv+gnxprvxq/iQV0yuEQTlyv2/ J6x9RaoHqCSLdoOKZa4uUJ2giTRXEVg2WtntGitBtmn/j95LdgjG8pgJPMLhWFJF66Wr jiwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Brw9s3yqqyX/Ik9f0mLhoLX1RMI4X/CZLtpJzeCpuyM=; b=koMhMd7vEtWNxXcTlJ9rwKjlrOOKDE0YbGEUjFA/4m8wdNjoBMWI8FLcCN+azsTFW0 clywf+4civz+qPq5gPElGVHEaxWXa4g18p/74xwAKhYHhCTD2eTJCakzfsXkw4p1x3f7 iQLizpuVpx+pEOFi+3j5MARnhOYixG0KUhM52REfUFuZpgg2vi2k5E00y4bBCFXeJf7R UftWXGwbUSRX81QxHty2cuOgDZpBN2Lco+twkW1GPqOL4pIQLF6G/+g/8L2QFBYoBWIZ nM8RJGd+mI59k1cAFYDxy+Y+3/XjOsJnHN5m3mp0cHdj8QnD+d7UZMZRlifJYirv+eSp x2dQ== X-Gm-Message-State: AJcUukehxtdgBFfwJVhw+OOANxDFiXkTEFb4utin4ItdkX4M8HkfdMT+ vCgYVGM2kilhqCtfwr4p2RwpBRGV X-Google-Smtp-Source: ALg8bN5tpUzwtGmVSMB8ubxJ1YHHNbW9+QpdoYNoMCHX1c1BTk61+u3TwO94Ca4K5clR+ptoti69iw== X-Received: by 2002:a17:902:6683:: with SMTP id e3mr6903140plk.93.1548348080759; Thu, 24 Jan 2019 08:41:20 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id 202sm28401926pfy.87.2019.01.24.08.41.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:41:19 -0800 (PST) Subject: Re: [PATCH net-next 0/4] net: IP defrag: use rbtrees in IPv6 defragmentation To: Peter Oskolkov , David Miller , netdev@vger.kernel.org Cc: Peter Oskolkov References: <20190122180253.128336-1-posk@google.com> From: Eric Dumazet Message-ID: <515f17ae-d520-552d-ac12-5c0e188cb699@gmail.com> Date: Thu, 24 Jan 2019 08:41:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190122180253.128336-1-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/22/2019 10:02 AM, Peter Oskolkov wrote: > Currently, IPv6 defragmentation code drops non-last fragments that > are smaller than 1280 bytes: see > commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu") > > This behavior is not specified in IPv6 RFCs and appears to break compatibility > with some IPv6 implementations, as reported here: > https://www.spinics.net/lists/netdev/msg543846.html > > This patchset contains four patches: > - patch 1 moves rbtree-related code from IPv4 to files shared b/w > IPv4/IPv6 > - patch 2 changes IPv6 defragmenation code to use rbtrees for defrag > queue > - patch 3 changes nf_conntrack IPv6 defragmentation code to use rbtrees > - patch 4 changes ip_defrag selftest to test changes made in the > previous three patches. > > Along the way, the 1280-byte restrictions are removed. Thanks a lot for following up on this Peter. Reviewed-by: Eric Dumazet