From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/2] sh_eth: add R-Car support for real Date: Tue, 09 Apr 2013 17:08:46 +0400 Message-ID: <516412DE.8020007@cogentembedded.com> References: <201303290051.32106.sergei.shtylyov@cogentembedded.com> <20130408023936.GA1643@verge.net.au> <20130408090451.GC8917@verge.net.au> <5162C9EA.6060005@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Simon Horman , linux-sh@vger.kernel.org, netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com To: phil.edworthy@renesas.com Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:37151 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933121Ab3DINJs (ORCPT ); Tue, 9 Apr 2013 09:09:48 -0400 Received: by mail-la0-f51.google.com with SMTP id fo12so1559227lab.10 for ; Tue, 09 Apr 2013 06:09:47 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 08-04-2013 18:40, phil.edworthy@renesas.com wrote: > Thanks for the patch. When I added r8a7779 support, I had a rather poor > manual with a lot of information missing. I submitted the patch once I got > the driver working on a Marzen board, with an REE Expansion Board. That must be 3rd type of the expansion board even. I have documentation on some Y-R-CAR-H1-BOARD-EXP board, and I have the R0P7779A00020S board mounted below Marzen. They seem very different as the latter don't have any switches on it. > One of the main changes you have made is adjusting the offset of the > control registers. When I did this work originally, I just assumed that > the base address start at 0x1DE00200, i.e. it included the 0x200 offset. > This made sense as the registers are then identically positioned to sh4a. Yes, but not all SH4 registers exist on R-Car and the Ether base is 0xFDE00000 according to the datasheet. > Regards > Phil WBR, Sergei