From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support Date: Thu, 11 Apr 2013 20:07:16 +0200 Message-ID: <5166FBD4.5020508@gmail.com> References: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> <1365702955.7355.5.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Jason Cooper , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, "David S. Miller" , Soeren Moch , Paul Mackerras , linux-arm-kernel@lists.infradead.org, Dale Farnsworth , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Florian Fainelli , Lennert Buytenhek To: Ben Hutchings Return-path: In-Reply-To: <1365702955.7355.5.camel@bwh-desktop.uk.solarflarecom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 04/11/2013 07:55 PM, Ben Hutchings wrote: > On Thu, 2013-04-11 at 14:40 +0200, Sebastian Hesselbarth wrote: >> This patch adds GRO support to mv643xx_eth by making it invoke >> napi_gro_receive instead of netif_receive_skb. > > The inet_lro support should be removed at the same time; inet_lro is now > deprecated and there should be no need to keep both of them. Ben, I agree on removing it asap, but I also like to see GRO support in. Maybe, we postpone lro removal just a little bit. I have just started to look at mv643xx_eth and remember Marvell Orion SoCs are not the only platform using it. I haven't heard a single word from ppc guys, yet. Willy just posted an experimental patch to remove lro. I'll have a look at it and test it out on Dove. Sebastian