From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Andreas Larsson <andreas@gaisler.com>,
"Hans J. Koch" <hjk@hansjkoch.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bill Pemberton <wfp5p@virginia.edu>,
linux-can@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v3] can: sja1000: fix endian on arm
Date: Thu, 11 Apr 2013 21:21:34 +0200 [thread overview]
Message-ID: <51670D3E.1020808@pengutronix.de> (raw)
In-Reply-To: <1365707697.4136.26.camel@mars>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On 04/11/2013 09:14 PM, Christoph Fritz wrote:
> To get correct endian on arm cpus while reading device tree properties,
> this patch replaces of_get_property() with of_property_read_u32().
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
[...]
> - prop = of_get_property(np, "nxp,clock-out-frequency", &prop_size);
> - if (prop && (prop_size == sizeof(u32)) && *prop) {
> - u32 divider = priv->can.clock.freq * 2 / *prop;
> + err = of_property_read_u32(np, "nxp,clock-out-frequency", &prop);
> + if (!err) {
What about checking for "prop != 0" as the original code does?
> + u32 divider = priv->can.clock.freq * 2 / prop;
To prevent a potential div-by-zero here?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-04-11 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 13:48 [PATCH] can: sja1000: use cpu endian Christoph Fritz
2013-04-08 13:57 ` Marc Kleine-Budde
2013-04-11 18:44 ` [PATCH v2] can: sja1000: fix endian on arm Christoph Fritz
2013-04-11 18:47 ` Marc Kleine-Budde
2013-04-11 18:53 ` Christoph Fritz
2013-04-11 19:14 ` [PATCH v3] " Christoph Fritz
2013-04-11 19:21 ` Marc Kleine-Budde [this message]
2013-04-11 19:32 ` [PATCH v4] " Christoph Fritz
2013-04-11 19:38 ` Marc Kleine-Budde
2013-04-12 11:18 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51670D3E.1020808@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andreas@gaisler.com \
--cc=chf.fritz@googlemail.com \
--cc=daniel@zonque.org \
--cc=grant.likely@secretlab.ca \
--cc=hjk@hansjkoch.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=wfp5p@virginia.edu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).