From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"annie.li@oracle.com" <annie.li@oracle.com>,
"wdauchy@gmail.com" <wdauchy@gmail.com>
Subject: Re: [PATCH 4/7] xen-netfront: frags -> slots in log message
Date: Fri, 12 Apr 2013 18:40:06 +0400 [thread overview]
Message-ID: <51681CC6.7070408@cogentembedded.com> (raw)
In-Reply-To: <20130409134745.GI16998@zion.uk.xensource.com>
Hello.
On 09-04-2013 17:47, Wei Liu wrote:
>>> Also fix a typo in comment.
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> ---
>>> drivers/net/xen-netfront.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
>>> index d9097a7..1bb2e20 100644
>>> --- a/drivers/net/xen-netfront.c
>>> +++ b/drivers/net/xen-netfront.c
>> [...]
>>> @@ -771,7 +771,7 @@ next:
>>>
>>> if (unlikely(slots > max)) {
>>> if (net_ratelimit())
>>> - dev_warn(dev, "Too many frags\n");
>>> + dev_warn(dev, "Too many slots\n");
>>
>> Shouldn't you have done this change as a part of patch #2?
> Because patch 2 has been applied to David Miller's tree, this is an
> incremental patch on top of that.
Why are you reposting already applied patch over and over again then?
> Wei.
WBR, Sergei
next prev parent reply other threads:[~2013-04-12 14:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 11:07 [PATCH V3 0/7] Bundle fixes for Xen netfront / netback Wei Liu
2013-04-09 11:07 ` [PATCH 1/7] xen-netfront: remove unused variable `extra' Wei Liu
2013-04-09 11:07 ` [PATCH 2/7] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-04-09 11:07 ` [PATCH 3/7] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-04-09 11:07 ` [PATCH 4/7] xen-netfront: frags -> slots in log message Wei Liu
2013-04-09 13:35 ` Sergei Shtylyov
2013-04-09 13:47 ` Wei Liu
2013-04-12 14:40 ` Sergei Shtylyov [this message]
2013-04-12 14:58 ` Wei Liu
2013-04-09 11:07 ` [PATCH 5/7] xen-netfront: reduce gso_max_size to account for ethernet header Wei Liu
2013-04-11 20:04 ` Wei Liu
2013-04-12 8:18 ` Ian Campbell
2013-04-12 8:48 ` Wei Liu
2013-04-12 8:57 ` Ian Campbell
2013-04-12 9:34 ` Wei Liu
2013-04-12 9:43 ` Ian Campbell
2013-04-12 12:58 ` Eric Dumazet
2013-04-12 13:29 ` Wei Liu
2013-04-12 13:36 ` Ian Campbell
2013-04-12 16:17 ` Ben Hutchings
2013-04-09 11:07 ` [PATCH 6/7] xen-netback: coalesce slots and fix regressions Wei Liu
2013-04-09 12:13 ` [Xen-devel] " Jan Beulich
2013-04-09 12:48 ` Wei Liu
2013-04-09 13:13 ` Jan Beulich
2013-04-09 13:48 ` Wei Liu
2013-04-09 11:07 ` [PATCH 7/7] xen-netback: don't disconnect frontend when seeing oversize packet Wei Liu
2013-04-09 11:34 ` David Laight
2013-04-09 11:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51681CC6.7070408@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wdauchy@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).