From: Florian Fainelli <f.fainelli@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: cristian.bercaru@freescale.com, netdev@vger.kernel.org,
madalin.bucur@freescale.com, shaohui.xie@freescale.com,
shruti@freescale.com
Subject: Re: [PATCH] net: phy: vitesse: advertise PAUSE frame capabilities on Vitesse PHY drivers
Date: Sat, 22 Feb 2014 10:08:44 -0800 [thread overview]
Message-ID: <5168669.8QxsYLHynZ@lenovo> (raw)
In-Reply-To: <1393076336.15717.97.camel@deadeye.wl.decadent.org.uk>
Le samedi 22 février 2014, 13:38:56 Ben Hutchings a écrit :
> On Fri, 2014-02-21 at 18:19 +0200, cristian.bercaru@freescale.com wrote:
> > From: Cristian Bercaru <cristian.bercaru@freescale.com>
> >
> > Enable the advertisment of symmetric and asymmetric PAUSE frame
> > capabilities on all Vitesse PHY drivers.
>
> I don't think this makes sense. So far as I know, pause frame support
> depends only on the MAC, not the PHY.
Agreed.
>
> I realise there are already other PHY drivers setting these flags, but
> why should they be added to every PHY driver individually when any
> autonegotiating PHY can advertise pause capability?
It looks like this might be abusing a PHY driver features to ensure that the
initial value fed to phydev->supported will make us advertise the pause
capabilities. This should be set by the Ethernet MAC driver prior to
phy_start(), not by the PHY driver.
>
> Ben.
>
> > Signed-off-by: Cristian Bercaru <cristian.bercaru@freescale.com>
> > ---
> >
> > drivers/net/phy/vitesse.c | 21 ++++++++++++++-------
> > 1 file changed, 14 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
> > index 14372c6..3124b31 100644
> > --- a/drivers/net/phy/vitesse.c
> > +++ b/drivers/net/phy/vitesse.c
> > @@ -227,7 +227,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8234,
> > .name = "Vitesse VSC8234",
> > .phy_id_mask = 0x000ffff0,
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc824x_config_init,
> > .config_aneg = &vsc82x4_config_aneg,
> >
> > @@ -239,7 +240,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8244,
> > .name = "Vitesse VSC8244",
> > .phy_id_mask = 0x000fffc0,
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc824x_config_init,
> > .config_aneg = &vsc82x4_config_aneg,
> >
> > @@ -251,7 +253,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8514,
> > .name = "Vitesse VSC8514",
> > .phy_id_mask = 0x000ffff0,
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc824x_config_init,
> > .config_aneg = &vsc82x4_config_aneg,
> >
> > @@ -263,7 +266,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8574,
> > .name = "Vitesse VSC8574",
> > .phy_id_mask = 0x000ffff0,
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc824x_config_init,
> > .config_aneg = &vsc82x4_config_aneg,
> >
> > @@ -275,7 +279,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8662,
> > .name = "Vitesse VSC8662",
> > .phy_id_mask = 0x000ffff0,
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc824x_config_init,
> > .config_aneg = &vsc82x4_config_aneg,
> >
> > @@ -288,7 +293,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8221,
> > .phy_id_mask = 0x000ffff0,
> > .name = "Vitesse VSC8221",
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc8221_config_init,
> > .config_aneg = &genphy_config_aneg,
> >
> > @@ -301,7 +307,8 @@ static struct phy_driver vsc82xx_driver[] = {
> >
> > .phy_id = PHY_ID_VSC8211,
> > .phy_id_mask = 0x000ffff0,
> > .name = "Vitesse VSC8211",
> >
> > - .features = PHY_GBIT_FEATURES,
> > + .features = PHY_GBIT_FEATURES |
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause,
> >
> > .flags = PHY_HAS_INTERRUPT,
> > .config_init = &vsc8221_config_init,
> > .config_aneg = &genphy_config_aneg,
--
Florian
prev parent reply other threads:[~2014-02-22 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 16:19 [PATCH] net: phy: vitesse: advertise PAUSE frame capabilities on Vitesse PHY drivers cristian.bercaru
2014-02-22 13:38 ` Ben Hutchings
2014-02-22 18:08 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5168669.8QxsYLHynZ@lenovo \
--to=f.fainelli@gmail.com \
--cc=ben@decadent.org.uk \
--cc=cristian.bercaru@freescale.com \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shaohui.xie@freescale.com \
--cc=shruti@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox