From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [net-next 02/11] ixgbe: Mask off check of frag_off as we only want fragment offset Date: Fri, 12 Apr 2013 14:34:26 -0700 Message-ID: <51687DE2.8000705@intel.com> References: <1365765866-15741-1-git-send-email-jeffrey.t.kirsher@intel.com> <1365765866-15741-3-git-send-email-jeffrey.t.kirsher@intel.com> <1365773328.4459.19.camel@edumazet-glaptop> <1365774332.4459.24.camel@edumazet-glaptop> <51683884.2010509@intel.com> <1365785511.4459.46.camel@edumazet-glaptop> <516850E4.8020504@intel.com> <1365792277.4459.67.camel@edumazet-glaptop> <51686AAF.4090105@intel.com> <1365798584.4459.70.camel@edumazet-glaptop> <51687725.5060008@intel.com> <1365801125.4459.73.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jeff Kirsher , davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com To: Eric Dumazet Return-path: Received: from mga02.intel.com ([134.134.136.20]:65160 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753031Ab3DLVe2 (ORCPT ); Fri, 12 Apr 2013 17:34:28 -0400 In-Reply-To: <1365801125.4459.73.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On 04/12/2013 02:12 PM, Eric Dumazet wrote: > On Fri, 2013-04-12 at 14:05 -0700, Alexander Duyck wrote: > >> The problem right now is if I call __skb_get_poff it will go >> through the portion of that path you didn't call out that does >> skb_copy_bits. > Absolutely not : skb->data_len is 0. > > How possibly can you say such things ? > > OK I give up with this topic. Yeah, we should agree to disagree since I think at some point we started arguing two different things. As for the patch that started this though we are good right? No problem with the patch itself, our discussion was over possible future work correct? Thanks, Alex