From: Paul Blakey <paulb@nvidia.com>
To: Alexander H Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Oz Shlomo <ozsh@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Roi Dayan <roid@nvidia.com>, Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH net-next v8 4/7] net/mlx5: Kconfig: Make tc offload depend on tc skb extension
Date: Mon, 6 Feb 2023 19:16:55 +0200 [thread overview]
Message-ID: <51691c67-33e4-01f0-c968-00c57c4dd86f@nvidia.com> (raw)
In-Reply-To: <86b7936aa6c306c61a782950c762fe3124229c51.camel@gmail.com>
On 06/02/2023 17:40, Alexander H Duyck wrote:
> On Sun, 2023-02-05 at 17:49 +0200, Paul Blakey wrote:
>> Tc skb extension is a basic requirement for using tc
>> offload to support correct restoration on action miss.
>>
>> Depend on it.
>>
>> Signed-off-by: Paul Blakey <paulb@nvidia.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
>> drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 --
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 --
>> 3 files changed, 1 insertion(+), 5 deletions(-)
>>
>
> So one question I had is what about the use of the SKB_EXT check in
> mlx5/core/en_tc.h? Seems like you could remove that one as well since
> it is wrapped in a check for MLX5_CLS_ACT before the check for
> NET_TC_SKB_EXT.
Good catch, ill remove it.
Thanks.
next prev parent reply other threads:[~2023-02-06 17:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 15:49 [PATCH net-next v8 0/7] net/sched: cls_api: Support hardware miss to tc action Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 1/7] " Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 2/7] net/sched: flower: Move filter handle initialization earlier Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 3/7] net/sched: flower: Support hardware miss to tc action Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 4/7] net/mlx5: Kconfig: Make tc offload depend on tc skb extension Paul Blakey
2023-02-06 15:40 ` Alexander H Duyck
2023-02-06 17:16 ` Paul Blakey [this message]
2023-02-05 15:49 ` [PATCH net-next v8 5/7] net/mlx5: Refactor tc miss handling to a single function Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 6/7] net/mlx5e: Rename CHAIN_TO_REG to MAPPED_OBJ_TO_REG Paul Blakey
2023-02-05 15:49 ` [PATCH net-next v8 7/7] net/mlx5e: TC, Set CT miss to the specific ct action instance Paul Blakey
2023-02-06 12:34 ` [PATCH net-next v8 0/7] net/sched: cls_api: Support hardware miss to tc action Ilya Maximets
2023-02-06 17:14 ` Paul Blakey
2023-02-07 0:20 ` Ilya Maximets
2023-02-07 5:03 ` Marcelo Leitner
2023-02-07 5:20 ` Jakub Kicinski
2023-02-08 8:41 ` Paul Blakey
2023-02-08 18:01 ` Marcelo Leitner
2023-02-09 0:09 ` Ilya Maximets
2023-02-09 1:09 ` Marcelo Leitner
2023-02-09 12:07 ` Ilya Maximets
2023-02-09 12:40 ` Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51691c67-33e4-01f0-c968-00c57c4dd86f@nvidia.com \
--to=paulb@nvidia.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).