From: Sridhar Samudrala <samudrala.sridhar@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, mike.rapoport@ravellosystems.com
Subject: Re: [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local"
Date: Sun, 14 Apr 2013 21:20:40 -0700 [thread overview]
Message-ID: <516B8018.80308@gmail.com> (raw)
In-Reply-To: <1365993080.5074.5.camel@cr0>
On 4/14/2013 7:31 PM, Cong Wang wrote:
> On Fri, 2013-04-12 at 16:07 -0700, Sridhar Samudrala wrote:
>> To address this behavior seen with veth, i had to change the if
>> condition to
>> check for rt->dst.dev->flags rather than rt->rt_flags.
> There is no specific IFF_ flag for veth, nor I think introducing one is
> a correct fix.
>
> I think we can just revert it for now, since it is not very easy to fix.
> You can, of course, send a bug-free version later. This regression
> blocks my VXLAN IPv6 support patches, by the way.
>
>
I am not suggesting adding a new IFF_ flag for veth. I was referring to the
IFF_LOOPBACKflag and it should work fine for your setup.
However, i think Mike Rapaport't patch that adds a check to test for
multicast/
broadcast routeisa better fix. Did you try that patch?
I tried it in my setup using both vxlan/DOVE configuration between VMs
in the
same networknamespace on 2 different bridges as well as the veth
configuration
between 2 network namespsaces.
Could you try his patch in your configuration. I think it will work and
if so
we should go withthat patch.
Thanks
Sridhar
prev parent reply other threads:[~2013-04-15 4:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:57 [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local" Cong Wang
2013-04-09 17:16 ` David Miller
2013-04-09 18:08 ` Sridhar Samudrala
2013-04-10 14:29 ` Sergei Shtylyov
2013-04-11 2:10 ` Cong Wang
2013-04-11 4:53 ` Sridhar Samudrala
2013-04-11 5:55 ` Cong Wang
2013-04-11 6:33 ` Sridhar Samudrala
2013-04-11 23:59 ` Sridhar Samudrala
2013-04-12 8:05 ` Cong Wang
2013-04-12 19:19 ` David Miller
2013-04-12 23:07 ` Sridhar Samudrala
2013-04-12 23:17 ` David Miller
2013-04-15 2:31 ` Cong Wang
2013-04-15 4:20 ` Sridhar Samudrala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516B8018.80308@gmail.com \
--to=samudrala.sridhar@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).