From: Paul Chavent <Paul.Chavent@onera.fr>
To: Willem de Bruijn <willemb@google.com>
Cc: richardcochran@gmail.com, edumazet@google.com,
daniel.borkmann@tik.ee.ethz.ch, xemul@parallels.com,
ebiederm@xmission.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net-packet: tx timestamping on tpacket ring
Date: Mon, 15 Apr 2013 09:31:14 +0200 [thread overview]
Message-ID: <516BACC2.7060400@onera.fr> (raw)
In-Reply-To: <1365879412-9541-1-git-send-email-willemb@google.com>
Hi.
On 04/13/2013 08:56 PM, Willem de Bruijn wrote:
> [...]
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -3311,7 +3311,7 @@ void skb_tstamp_tx(struct sk_buff *orig_skb,
> * so keep the shared tx_flags and only
> * store software time stamp
> */
> - skb->tstamp = ktime_get_real();
> + orig_skb->tstamp = skb->tstamp = ktime_get_real();
> }
You said that "the orig_skb is usually freed shortly after
skb_tstamp_tx is called".
So i suppose that if you had coded it, that's because this orig_skb is
the one that is given to the skb destructor. So when you call
__packet_set_timestamp, in tpacket_destruct_skb, you get this timestamp
? Am i right ?
Why we couldn't call
*skb_hwtstamps(orig_skb) = *skb_hwtstamps(skb) = *hwtstamps;
in order to get the hardware timestamping too ?
Thank for your help.
Paul.
next prev parent reply other threads:[~2013-04-15 7:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 15:29 [RFC] net : add tx timestamp to packet mmap Paul Chavent
2012-12-12 19:23 ` David Miller
2012-12-13 7:13 ` Paul Chavent
2012-12-13 13:29 ` Richard Cochran
2012-12-13 16:13 ` Paul Chavent
2012-12-13 18:17 ` Richard Cochran
2012-12-14 7:57 ` Paul Chavent
2013-04-09 10:42 ` Paul Chavent
2013-04-09 13:15 ` Richard Cochran
2013-04-13 18:33 ` Willem de Bruijn
2013-04-13 18:56 ` [PATCH] net-packet: tx timestamping on tpacket ring Willem de Bruijn
2013-04-13 22:18 ` Daniel Borkmann
2013-04-13 22:47 ` David Miller
2013-04-14 0:04 ` Willem de Bruijn
2013-04-14 0:16 ` Willem de Bruijn
2013-04-14 0:49 ` Willem de Bruijn
2013-04-14 5:16 ` Daniel Borkmann
2013-04-14 0:00 ` Willem de Bruijn
2013-04-14 10:52 ` Daniel Borkmann
2013-04-14 13:07 ` Richard Cochran
2013-04-15 7:37 ` Paul Chavent
2013-04-15 16:56 ` Richard Cochran
2013-04-15 16:59 ` Willem de Bruijn
2013-04-17 10:22 ` Richard Cochran
2013-04-19 21:51 ` [PATCH net-next v2] packet: " Willem de Bruijn
2013-04-20 12:33 ` Daniel Borkmann
2013-04-21 2:30 ` Willem de Bruijn
2013-04-21 10:10 ` Daniel Borkmann
2013-04-21 16:42 ` Willem de Bruijn
2013-04-21 18:14 ` Daniel Borkmann
2013-04-22 8:19 ` Paul Chavent
2013-04-22 10:25 ` Daniel Borkmann
2013-04-22 14:23 ` Willem de Bruijn
2013-04-20 16:43 ` Richard Cochran
2013-04-21 2:34 ` Willem de Bruijn
2013-04-15 15:41 ` [PATCH] net-packet: " Paul Chavent
2013-04-15 9:45 ` David Laight
2013-04-15 17:08 ` Willem de Bruijn
2013-04-15 17:31 ` David Miller
2013-04-15 7:31 ` Paul Chavent [this message]
2013-04-15 16:37 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516BACC2.7060400@onera.fr \
--to=paul.chavent@onera.fr \
--cc=daniel.borkmann@tik.ee.ethz.ch \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).