From: Mugunthan V N <mugunthanvnm@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received.
Date: Wed, 17 Apr 2013 15:38:18 +0530 [thread overview]
Message-ID: <516E7492.9090608@ti.com> (raw)
In-Reply-To: <516E6538.8060804@linutronix.de>
On 4/17/2013 2:32 PM, Sebastian Andrzej Siewior wrote:
> On 04/17/2013 10:46 AM, Mugunthan V N wrote:
>> On 4/17/2013 1:14 PM, Sebastian Andrzej Siewior wrote:
>>>> I have tested this patch and it hangs the CPU after net open (CPSW
>>>> init).
>>> If I remove additionally the napi_schedule() piece then the network is
>>> dead (as expected) and the system continues to work (and I receive
>>> interrupts) and the ISR for cpsw is not executed again. What hardware /
>>> CPU do you have?
>>>
>> I am testing on Beagle Bone black.
> I have here vanila v3.8.4 + cpsw patches which were in net-next. As for
> the hardware:
>
> [ 0.000000] Machine: Generic AM33XX (Flattened Device Tree), model:
> TI AM335x BeagleBone
> [ 0.000000] AM335X ES1.0 (neon )
>
> model name : ARMv7 Processor rev 2 (v7l)
> CPU implementer : 0x41
> CPU architecture: 7
> CPU variant : 0x3
> CPU part : 0xc08
> CPU revision : 2
>
> If we do have the same hardware and source why do I have different
> behavior? Can you send me your .config off-list?
>
Mine shows [ 0.000000] AM335X ES2.0 (neon )
In Beagle bone (silicon revision 1.0) there is a bug in CPSW irq in
Silicon, please refer
http://www.ti.com/lit/er/sprz360e/sprz360e.pdf Advisory 1.0.9
Beagle bone black has Silicon revision 2.0 where the bug is fixed and
you are able
to test it properly and it hangs in my bone black as the IRQ is properly
connected
to A8
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-04-17 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 18:21 [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received Sebastian Andrzej Siewior
2013-04-17 6:19 ` Mugunthan V N
2013-04-17 7:44 ` Sebastian Andrzej Siewior
2013-04-17 8:46 ` Mugunthan V N
2013-04-17 9:02 ` Sebastian Andrzej Siewior
2013-04-17 10:08 ` Mugunthan V N [this message]
2013-04-17 10:49 ` Sebastian Andrzej Siewior
2013-04-17 11:44 ` Mugunthan V N
2013-04-17 11:55 ` D-Link DUB E100 C1 not working when pinged by "ping 172.17.0.1 -c 1 -s 1965" Dean Jenkins
2013-04-17 21:12 ` [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received Sebastian Andrzej Siewior
2013-04-17 9:19 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E7492.9090608@ti.com \
--to=mugunthanvnm@ti.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).