From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH net-next 9/9] net: sctp: sctp_ulpq: do not use char as a struct member Date: Wed, 17 Apr 2013 11:36:55 -0400 Message-ID: <516EC197.1080206@gmail.com> References: <1366146438-8815-1-git-send-email-dborkman@redhat.com> <1366146438-8815-10-git-send-email-dborkman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mail-qe0-f54.google.com ([209.85.128.54]:59048 "EHLO mail-qe0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934559Ab3DQPg6 (ORCPT ); Wed, 17 Apr 2013 11:36:58 -0400 In-Reply-To: <1366146438-8815-10-git-send-email-dborkman@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 04/16/2013 05:07 PM, Daniel Borkmann wrote: > Replace char with a more appropriate __u8 bitfield for pd_mode. > > Signed-off-by: Daniel Borkmann > --- > include/net/sctp/ulpqueue.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/sctp/ulpqueue.h b/include/net/sctp/ulpqueue.h > index 00e50ba..a2bebd4 100644 > --- a/include/net/sctp/ulpqueue.h > +++ b/include/net/sctp/ulpqueue.h > @@ -49,10 +49,10 @@ > > /* A structure to carry information to the ULP (e.g. Sockets API) */ > struct sctp_ulpq { > - char pd_mode; > struct sctp_association *asoc; > struct sk_buff_head reasm; > struct sk_buff_head lobby; > + __u8 pd_mode:1; > }; > > /* Prototypes. */ > This one is a bit pointless. You are not saving any space and making generated code worse. -vlad