From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends
Date: Mon, 22 Jan 2018 21:18:47 -0800
Message-ID: <516d6a03-9b08-4782-6fa4-ccff7488563e@gmail.com>
References: <20180123043044.2144-1-bhole_prashant_q7@lab.ntt.co.jp>
 <20180123043839.kg6ffx2q7iezuswy@ast-mbp>
 <902e1164-d4a3-6fae-1f29-8b7433a18710@lab.ntt.co.jp>
 <20180123050108.fcmh4phzcclxer2f@ast-mbp>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S . Miller" <davem@davemloft.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Shuah Khan <shuahkh@osg.samsung.com>, netdev@vger.kernel.org
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f170.google.com ([209.85.192.170]:33878 "EHLO
        mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750880AbeAWFTB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 23 Jan 2018 00:19:01 -0500
Received: by mail-pf0-f170.google.com with SMTP id e76so8922185pfk.1
        for <netdev@vger.kernel.org>; Mon, 22 Jan 2018 21:19:01 -0800 (PST)
In-Reply-To: <20180123050108.fcmh4phzcclxer2f@ast-mbp>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 01/22/2018 09:01 PM, Alexei Starovoitov wrote:
> On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote:
>>
>>
>> On 1/23/2018 1:38 PM, Alexei Starovoitov wrote:
>>> On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote:
>>>> Bug: BPF programs and maps related to sockmaps test exist in
>>>> memory even after test_maps ends
>>>>
>>>> This patch fixes it by empyting sockmaps when test ends.
>>>>
>>>> Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests")
>>>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>>>
>>> that's a fine workaround and I'm planning to apply this patch
>>> to bpf-next, but it's not a fix. The sockmap should have cleaned
>>> itself up.
>>
>> Ok. Do I need to re-submit it targeted to -bpf-next and without fixes tag?
> 
> No need. It's fine.
> 

Also I'm looking over sockmap code now for the bug, should have
something shortly.

Agree this is a nice cleanup of the test code though. On the other
hand I should add some explicit tests for this case (deleting map
with elements) as well though.

.John