From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: netdev@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com
Subject: Re: [PATCH v2 7/8] net: sh-eth: Remove ifdef for sh_eth_select_mii
Date: Thu, 18 Apr 2013 18:36:45 +0400 [thread overview]
Message-ID: <517004FD.9060906@cogentembedded.com> (raw)
In-Reply-To: <1366279869-23387-7-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Hello.
On 18-04-2013 14:11, Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
That's what I was going to do first.
> drivers/net/ethernet/renesas/sh_eth.c | 4 ----
> 1 file changed, 4 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index a4e337f..eb428d4 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -313,9 +313,6 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = {
> [TSU_ADRL31] = 0x01fc,
> };
>
> -#if defined(CONFIG_CPU_SUBTYPE_SH7734) || \
> - defined(CONFIG_CPU_SUBTYPE_SH7763) || \
> - defined(CONFIG_ARCH_R8A7740)
> static void sh_eth_select_mii(struct net_device *ndev)
Don't you want to annotate the function with __maybe_unused?
WBR, Sergei
next prev parent reply other threads:[~2013-04-18 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 10:11 [PATCH v2 1/8] net: sh-eth: Remove ifdef from definition of bit of EDSR and GECMR Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 2/8] net: sh-eth: Set EDSR_ENALL instead of 0x03 is set to EDSR Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 3/8] net: sh-eth: Remove duplicate sh_eth_set_duplex() Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 4/8] net: sh-eth: Remove SH_ETH_HAS_TSU and use tsu of sh_eth_cpu_data instead Nobuhiro Iwamatsu
2013-04-18 14:40 ` Sergei Shtylyov
2013-05-07 2:57 ` Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 5/8] net: sh-eth: Add CONFIG_PM to definition of dev_pm_ops Nobuhiro Iwamatsu
2013-04-18 14:53 ` Sergei Shtylyov
2013-05-07 2:57 ` Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 6/8] net: sh-eth: Add irq configureation flags in sh_eth_cpu_data Nobuhiro Iwamatsu
2013-04-18 14:57 ` Sergei Shtylyov
2013-05-07 2:57 ` Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 7/8] net: sh-eth: Remove ifdef for sh_eth_select_mii Nobuhiro Iwamatsu
2013-04-18 14:36 ` Sergei Shtylyov [this message]
2013-05-07 5:00 ` Nobuhiro Iwamatsu
2013-04-18 10:11 ` [PATCH v2 8/8] net: sh-eth: Rewrite sh_eth_reset function Nobuhiro Iwamatsu
2013-04-18 14:50 ` [PATCH v2 1/8] net: sh-eth: Remove ifdef from definition of bit of EDSR and GECMR Sergei Shtylyov
2013-05-07 2:57 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517004FD.9060906@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).