From: Gertjan van Wingerde <gwingerde-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
rt2x00 Users List
<users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org>
Subject: Re: [PATCH wireless-next V2] rt2x00: Use more current logging styles, shrink object size
Date: Fri, 19 Apr 2013 20:29:56 +0200 [thread overview]
Message-ID: <51718D24.3020902@gmail.com> (raw)
In-Reply-To: <1366385620.3901.28.camel@joe-AO722>
On 04/19/13 17:33, Joe Perches wrote:
> Reduce object space ~2% using more current logging styles.
>
> Neaten and simplify logging macros.
> Use wiphy_<level> where appropriate.
> Coalesce formats.
>
> Convert ERROR/WARNING/INFO macros to rt2x00_<level>
> Convert EEPROM to rt2x00_eeprom_dbg
> Convert PROBE_ERROR to rt2x00_probe_err
> Convert DEBUG to rt2x00_dbg
> Convert EEPROM to rt2x00_eeprom_dbg
>
> $ size drivers/net/wireless/rt2x00/built-in.o*
> text data bss dec hex filename
> 245639 71696 69584 386919 5e767 drivers/net/wireless/rt2x00/built-in.o.new
> 240609 70096 68944 379649 5cb01 drivers/net/wireless/rt2x00/built-in.o.new.nodyndbg
> 240609 70096 68944 379649 5cb01 drivers/net/wireless/rt2x00/built-in.o.new.no_rt2x00_debug
> 249198 70096 70352 389646 5f20e drivers/net/wireless/rt2x00/built-in.o.old
> 249198 70096 70352 389646 5f20e drivers/net/wireless/rt2x00/built-in.o.old.nodyndbg
> 244222 70096 69712 384030 5dc1e drivers/net/wireless/rt2x00/built-in.o.old.no_rt2x00_debug
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Acked-by: Gertjan van Wingerde <gwingerde-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> V2 differences:
>
> Correct copy/paste error in rt2x00_info/warn macros
> Reorder macro definitions
> Use embedded prefix in rt2x00_eeprom_dbg
>
> Object size increased from v1 ~100 bytes x86/32.
> Object size may be slightly smaller this way for x86/64
>
>
---
Gertjan
prev parent reply other threads:[~2013-04-19 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 8:33 [PATCH wireless-next] rt2x00: Use more current logging styles, shrink object size Joe Perches
2013-04-19 9:45 ` Gertjan van Wingerde
2013-04-19 9:52 ` Joe Perches
2013-04-19 15:33 ` [PATCH wireless-next V2] " Joe Perches
2013-04-19 18:29 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51718D24.3020902@gmail.com \
--to=gwingerde-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).