From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH v2 net-next 2/6] bridge: make flags sysfs interface a little bit more extensible Date: Fri, 19 Apr 2013 17:35:26 -0400 Message-ID: <5171B89E.4050800@redhat.com> References: <1366404770-28523-1-git-send-email-vyasevic@redhat.com> <1366404770-28523-3-git-send-email-vyasevic@redhat.com> <20130419135441.2dc84327@nehalam.linuxnetplumber.net> Reply-To: vyasevic@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, mst@redhat.com To: Stephen Hemminger Return-path: In-Reply-To: <20130419135441.2dc84327@nehalam.linuxnetplumber.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 04/19/2013 04:54 PM, Stephen Hemminger wrote: > On Fri, 19 Apr 2013 16:52:46 -0400 > Vlad Yasevich wrote: > >> >> +static ssize_t show_flag(struct net_bridge_port *p, char *buf, >> + unsigned long mask) >> +{ >> + return sprintf(buf, "%d\n", !!(p->flags & mask)); >> +} > > Flags are bit, show in hex please. > I did not change the output format. In fact, on second look I can pull this change out as it isn't needed. -vlad