From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH 3/5 v2] net/cpsw: don't rely only on netif_running() to check which device is active Date: Mon, 22 Apr 2013 15:10:23 +0530 Message-ID: <51750587.5020801@ti.com> References: <1366235536-15744-1-git-send-email-bigeasy@linutronix.de> <1366235536-15744-4-git-send-email-bigeasy@linutronix.de> <516FDE0A.70504@ti.com> <516FE2AD.2040403@linutronix.de> <51711E0B.4000306@ti.com> <20130422083048.GA8162@linutronix.de> <5174FF93.8070408@ti.com> <51750334.8050807@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , "David S. Miller" To: Sebastian Andrzej Siewior Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:52090 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756015Ab3DVJmF (ORCPT ); Mon, 22 Apr 2013 05:42:05 -0400 In-Reply-To: <51750334.8050807@linutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On 4/22/2013 3:00 PM, Sebastian Andrzej Siewior wrote: > On 04/22/2013 11:14 AM, Mugunthan V N wrote: >>> How about this? >> If this is the case, then other Ethernet drivers will also have the same >> scenario, >> if it can be fixed in a generic way then i will be good. > Other ethernet drivers know if their device generated an interrupt, > stop the source and schedule napi. But here it could be either the > device or the slave device, right? > After writing this, a better idea idea just bumped into my head. > > btw: Any update on http://www.spinics.net/lists/netdev/msg233296.html? > Yes, when interrupt is disabled in hardware then interrupt must be disabled in my initial days i have verified it, CPSW doesn't allow any new interrupts to propagate to arm if CPSW interrupt is disabled but there is an issue. CPSW irq signal is not directly connected to irq controller, it is connected via edge to level conversion so if one interrupt reaches arm, irq controller has to be disabled else arm get blocked in CPSW ISR. Regards Mugunthan V N