From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Mugunthan V N <mugunthanvnm@ti.com>,
tglx@linutronix.de, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/4] net/cpsw: make sure modules remove does not leak any ressources
Date: Thu, 25 Apr 2013 16:47:13 +0400 [thread overview]
Message-ID: <517925D1.2030509@cogentembedded.com> (raw)
In-Reply-To: <1366829305-9752-3-git-send-email-bigeasy@linutronix.de>
Hello.
On 24-04-2013 22:48, Sebastian Andrzej Siewior wrote:
> This driver does not clean up properly after leaving. Here is a list:
> - Use unregister_netdev(). free_netdev() is good but not enough
> - Use the above also on the other ndev in case of dual mac
> - Free data.slave_data. The name of the strucre makes it look like
s/strucre/structure/
> it is platform_data but it is not. It is just a trick!
> - Free all irqs. Again: freeing one irq is good start, but freeing all
> of them is better.
> With this rmmod & modprobe of cpsw seems to work. The remaining issue
> is:
> |WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0x9c/0xd4()
> |sysfs: cannot create duplicate filename '/devices/ocp.2/4a100000.ethernet/4a101000.mdio'
> |WARNING: at lib/kobject.c:196 kobject_add_internal+0x1a4/0x1c8()
> comming from of_platform_populate() and I am not sure that this belongs
> here.
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
WBR, Sergei
next prev parent reply other threads:[~2013-04-25 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 18:48 Second batch of cpsw patches Sebastian Andrzej Siewior
2013-04-24 18:48 ` [PATCH 1/4] net/ti: add MODULE_DEVICE_TABLE + MODULE_LICENSE Sebastian Andrzej Siewior
2013-04-25 6:29 ` Mugunthan V N
2013-04-24 18:48 ` [PATCH 2/4] net/cpsw: make sure modules remove does not leak any ressources Sebastian Andrzej Siewior
2013-04-25 6:31 ` Mugunthan V N
2013-04-25 12:47 ` Sergei Shtylyov [this message]
2013-04-24 18:48 ` [PATCH 3/4] net/cpsw: optimize the for_each_slave_macro() Sebastian Andrzej Siewior
2013-04-25 6:31 ` Mugunthan V N
2013-04-24 18:48 ` [PATCH 4/4] net/cpsw: fix irq_disable() with threaded interrupts Sebastian Andrzej Siewior
2013-04-25 6:35 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517925D1.2030509@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).