From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] 3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA) Date: Fri, 26 Apr 2013 01:24:15 +0400 Message-ID: <51799EFF.10003@cogentembedded.com> References: <1366921743-6440-1-git-send-email-tedheadster@gmail.com> <51799A39.6070002@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Matthew Whitehead , netdev@vger.kernel.org To: Andrew Morton Return-path: Received: from mail-la0-f43.google.com ([209.85.215.43]:46874 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758043Ab3DYVZd (ORCPT ); Thu, 25 Apr 2013 17:25:33 -0400 Received: by mail-la0-f43.google.com with SMTP id ea20so2997707lab.2 for ; Thu, 25 Apr 2013 14:25:31 -0700 (PDT) In-Reply-To: <51799A39.6070002@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 26-04-2013 1:03, Sergei Shtylyov wrote: >> From: Matthew Whitehead >> The venerable 3c509 driver only sets its device parent in one case, the >> ISAPnP one. >> It does this with the SET_NETDEV_DEV function. It should register with the >> device >> hierarchy in two additional cases: standard (non-PnP) ISA and EISA. >> - Currently they appear here: >> /sys/devices/virtual/net/eth0 (standard ISA) >> /sys/devices/virtual/net/eth1 (EISA) >> - Rather, they should instead be here: >> /sys/devices/isa/3c509.0/net/eth0 (standard ISA) >> /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA) >> Tested on ISA and EISA boards. > That's good but you forgot to sign off, so the patch can't be applied. > BTW, it seems that after almost 7 years I seem to have found a tester for > my patch which lingered all this time in the Andrew Morton's tree! You've said > you have EISA boards, how about testing my patch? Now if I could find Andrew > Morton's tree... Andrew? Found it at last at ozlabs.org but it turned out that Andrew has dropped the patch without notifying me. :-( WBR, Sergei