From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable Date: Fri, 26 Apr 2013 17:48:08 +0400 Message-ID: <517A8598.3090602@cogentembedded.com> References: <1366975848-31503-1-git-send-email-mugunthanvnm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-omap@vger.kernel.org, Sebastian Siewior To: Mugunthan V N Return-path: In-Reply-To: <1366975848-31503-1-git-send-email-mugunthanvnm@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 26-04-2013 15:30, Mugunthan V N wrote: > With the commit id a11fbba Please also specify that commit's summary line in parens. > from Sebastian Siewior, a kernel warning is > generated as below. This warning is generated as the irq_enabled is not > initialized for the primary interface and in probe it is initialized for > the secondary interface. This patch moves irq_enabled initialization from > second interface to primary interface. s/second/secondary/? > [ 3.049173] net eth0: phy found : id is : 0x4dd074 > [ 3.054552] net eth0: phy found : id is : 0x4dd074 > [ 3.070421] ------------[ cut here ]------------ > [ 3.075308] WARNING: at kernel/irq/manage.c:437 enable_irq+0x3c/0x74() > [ 3.082173] Unbalanced enable for IRQ 56 > [ 3.086299] Modules linked in: > [ 3.089557] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath_common+0x4c/0x68) > [ 3.099450] [] (warn_slowpath_common+0x4c/0x68) from [] (warn_slowpath_fmt+0x30/0x40) > [ 3.109521] [] (warn_slowpath_fmt+0x30/0x40) from [] (enable_irq+0x3c/0x74) > [ 3.118681] [] (enable_irq+0x3c/0x74) from [] (cpsw_ndo_open+0x61c/0x684) > [ 3.127669] [] (cpsw_ndo_open+0x61c/0x684) from [] (__dev_open+0x9c/0xf8) > [ 3.136646] [] (__dev_open+0x9c/0xf8) from [] (__dev_change_flags+0x78/0x13c) > [ 3.145988] [] (__dev_change_flags+0x78/0x13c) from [] (dev_change_flags+0x10/0x48) > [ 3.155884] [] (dev_change_flags+0x10/0x48) from [] (ip_auto_config+0x198/0x111c) > [ 3.165592] [] (ip_auto_config+0x198/0x111c) from [] (do_one_initcall+0x34/0x180) > [ 3.175309] [] (do_one_initcall+0x34/0x180) from [] (kernel_init_freeable+0xfc/0x1c8) > [ 3.185393] [] (kernel_init_freeable+0xfc/0x1c8) from [] (kernel_init+0x8/0xe4) > [ 3.194929] [] (kernel_init+0x8/0xe4) from [] (ret_from_fork+0x14/0x24) > [ 3.203712] ---[ end trace d6f979da080bc391 ]--- > Cc: Sebastian Siewior > Signed-off-by: Mugunthan V N WBR, Sergei