From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH V3 2/3] ARM: net: bpf_jit: make code generation less dependent on struct sk_filter. Date: Sat, 27 Apr 2013 00:30:19 +0200 Message-ID: <517AFFFB.9090201@redhat.com> References: <1366824429-26652-1-git-send-email-nschichan@freebox.fr> <1366824429-26652-3-git-send-email-nschichan@freebox.fr> <3592414.M8kQZLCXlW@wuerfel> <20130426122601.10ec05fcb4860df1b0a5b409@linux-foundation.org> <517AD9E2.2090704@redhat.com> <20130426130948.cbfd2f6256afc0e3ee7abeed@linux-foundation.org> <517AF926.3020302@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Arnd Bergmann , Nicolas Schichan , Will Drewry , Mircea Gherzan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , "David S. Miller" , Daniel Borkmann , netdev@vger.kernel.org To: Xi Wang Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 04/27/2013 12:18 AM, Xi Wang wrote: > Thanks for CCing. One way to clean up this would be to refactor the > bpf jit interface as: > > bpf_func_t bpf_jit_compile(struct sock_filter *filter, unsigned int flen); > void bpf_jit_free(bpf_func_t bpf_func); > > Then both packet and seccomp filters can share the unified interface. > Also, we don't need seccomp_filter_get_len() and other helpers. > > Do you want me to rebase my patch against linux-next and see how that goes? Sure, whatever works for you. Not sure if it will still make it though. Also, as Eric already mentioned earlier, please do not top-post your mails! I think one reminder should be sufficient for that. ;-)