public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: shemminger@vyatta.com
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jan Engelhardt <jengelh@inai.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: PATCH iproute2] catch iptables interface changes
Date: Sun, 28 Apr 2013 10:44:38 -0400	[thread overview]
Message-ID: <517D35D6.8090606@mojatatu.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]


Thanks to Jan for this suggestion.
Hopefully this would ease some of the pain.

cheers,
jamal

[-- Attachment #2: catch-ipt-upgrade --]
[-- Type: text/plain, Size: 815 bytes --]

commit ba9b18dbcad853e22ea2b8ecf87d53ef2f6cf58c
Author: Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Sun Apr 28 07:41:47 2013 -0400

    Detect future iptable changes interfaces earlier in the dev
    cycles. Hopefully someone is going to complain about such breakage
    and we'll get the fix in sooner.
    
    Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

diff --git a/tc/m_xt.c b/tc/m_xt.c
index 3edf520..b266337 100644
--- a/tc/m_xt.c
+++ b/tc/m_xt.c
@@ -129,6 +129,10 @@ static int parse_ipt(struct action_util *a,int *argc_p,
 	__u32 hook = 0, index = 0;
 	struct option *opts = NULL;
 
+#if (XTABLES_VERSION_CODE > 7)
+#error Someone call the guy who changed xtables ver 7 and \
+	make him fix it^W^W^W^W say you need help.
+#endif
 	xtables_init_all(&tcipt_globals, NFPROTO_IPV4);
 	set_lib_dir();
 

             reply	other threads:[~2013-04-28 14:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-28 14:44 Jamal Hadi Salim [this message]
2013-05-04 15:57 ` PATCH iproute2] catch iptables interface changes Jamal Hadi Salim
2013-05-06 15:09 ` Stephen Hemminger
2013-05-06 16:53 ` Pablo Neira Ayuso
2013-05-06 17:23   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517D35D6.8090606@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=jengelh@inai.de \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox