From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98812CA9EB9 for ; Sat, 26 Oct 2019 12:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67CF82064A for ; Sat, 26 Oct 2019 12:26:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="tzUB9GQO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbfJZM0U (ORCPT ); Sat, 26 Oct 2019 08:26:20 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:43305 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfJZM0U (ORCPT ); Sat, 26 Oct 2019 08:26:20 -0400 Received: by mail-il1-f196.google.com with SMTP id t5so4148021ilh.10 for ; Sat, 26 Oct 2019 05:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+WlWbArEoZ65OVk4YiNQUfNCgdtey9GvKbDmhX7iLjw=; b=tzUB9GQO40LFx5308DljGRz7vdwiU5V/5RIa63W0qh4itrJIBZ27GqJqf9EsV9RqWp VgoGPmF+JNyr9+sCXumIA4A15KqiR3xNeb2VSfQUIdUf7FujYMlgKr7j6kZuUJ2ApppQ q5ekq/40zt1rY6zYyk45eZgdGh/1cTgbxq20EHgvoadmMxCUjRWwd2O+gMN5ujaivwKR 4VBr4nBsNnMUOnFRDjJucSkkx79gTkQ6pM+kD5UJI1CTpPwmoOQmt7H9FzbioXLUUgpP jCv6HX4Zi6fCQmdhsNuDZL2RhkdZ6iywpBGAwBeWJxlyD3GYMwr9JqiFK2LFFQArszNP cZ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+WlWbArEoZ65OVk4YiNQUfNCgdtey9GvKbDmhX7iLjw=; b=alda4JlVUAi6/LKONarBkrB4GewBeTrBp6Y7ew9Ni+uhbdfZzRWjr+3QMAThsdRNX7 4+y+l8DvLYZvzQre4+UIS/OuH4qUhAiCdhsUCUUaSk3wnWB4xmVECsVHl4yfJOV+Dzi7 ocax56ewZd7V752VnhD7lfKhQqlpW4Iw8P/qBOZMreTirqyuRYsBCKg+VuwLxkn40Nbv SMx3mlLaBTCDom3od8DImz7xKrlCb/ybm91LhGuo3Xg4Anbh9AcY7stmTAFrewL3bue9 cyIqLwl3s54is25AYhbqaPcaAfkDDiRLzrDe2g8SPg+DfTnMKezkxpeC3uZkj4pflefb 1DZw== X-Gm-Message-State: APjAAAWgYU2qqpPAqvwU12HHdUrVjoB5auDsbXh3e8u30r7cg0Jn/LNW pdyd2JHpfR8ZysvKguSmsFI91g== X-Google-Smtp-Source: APXvYqzOxk/l/Wxkh8utdeRN4pKww/UT4nKwaUOKLVP1vejWb9MmXiQ4WqWEa9lHAWxu/E72hktoAA== X-Received: by 2002:a92:8189:: with SMTP id q9mr10381135ilk.38.1572092779363; Sat, 26 Oct 2019 05:26:19 -0700 (PDT) Received: from [192.168.0.124] (198-84-204-252.cpe.teksavvy.com. [198.84.204.252]) by smtp.googlemail.com with ESMTPSA id i7sm568124iog.10.2019.10.26.05.26.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Oct 2019 05:26:17 -0700 (PDT) Subject: Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag To: Vlad Buslov Cc: Jiri Pirko , "netdev@vger.kernel.org" , "xiyou.wangcong@gmail.com" , "davem@davemloft.net" , "mleitner@redhat.com" , "dcaratti@redhat.com" , Eric Dumazet References: <20191022141804.27639-1-vladbu@mellanox.com> <78ec25e4-dea9-4f70-4196-b93fbc87208d@mojatatu.com> <20191024073557.GB2233@nanopsycho.orion> <90c329f6-f2c6-240f-f9c1-70153edd639f@mojatatu.com> <48a75bf9-d496-b265-bdb7-025dd2e5f9f9@mojatatu.com> <7488b589-4e34-d94e-e8e1-aa8ab773891e@mojatatu.com> <43d4c598-88eb-27b3-a4bd-c777143acf89@mojatatu.com> <07a6ceec-3a87-44cb-f92d-6a6d9d9bef81@mojatatu.com> <894e7d98-83b0-2eaf-000e-0df379e2d1f4@mojatatu.com> <710bf705-6a58-c158-4fdc-9158dfa34ed3@mojatatu.com> From: Jamal Hadi Salim Message-ID: <517f26b9-89cc-df14-c903-e750c96d5713@mojatatu.com> Date: Sat, 26 Oct 2019 08:26:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-10-26 5:44 a.m., Vlad Buslov wrote: > > Okay, I understand now what you suggest. But why not unify cls and act > API, and always have flags parsed in tcf_action_init_1() as > TCA_ACT_ROOT_FLAGS like I suggested in one of my previous mails? That > way we don't have to pass pointers around. That would work. I am being a sucker for optimization - one flag for a batch of actions vs one per action. It is a good compromise, go for it. cheers, jamal