From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: netdev@vger.kernel.org, klassert@mathematik.tu-chemnitz.de,
tedheadster@gmail.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] 3c59x: fix PCI resource management
Date: Thu, 02 May 2013 21:40:53 +0400 [thread overview]
Message-ID: <5182A525.8020601@cogentembedded.com> (raw)
In-Reply-To: <51819C12.2060103@cogentembedded.com>
Hello.
On 02-05-2013 2:49, Sergei Shtylyov wrote:
>> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> The driver wrongly claimed I/O ports at an address returned by pci_iomap() --
>> even if it was passed an MMIO address. Fix this by claiming/releasing all PCI
>> resources in the PCI driver probe()/remove() methods instead and get rid of the
>> 'must_free_region' flag weirdness (why would Cardbus claim anything for us?).
>> Also, the remove() method was trying to talk to the chip after having disabled
>> its address decoders (at least on x86) -- fix this and while doing it get rid
>> of the useless VORTEX_PCI() invocations.
>> While at it, fix some cases of the overly indented code and the code crossing
>> a 80-column boundary...
>> [akpm@linux-foundation.org: coding-style fixes]
>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> Cc: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> ---
>> The patch is against David Miller's 'net-next.git' repo.
>> Matthew, please test it on one of your 3c59x EISA boards.
>> Steffen, here's my second try to get this patch past you, the last one was back
>> in 2009...
> This is mostly a request for testing at this point, I forgot to add [RFT]
> to the subject...
David and others, your comments are welcome however. The patch probably
needs some more trimming before it can be considered a pure fix. It has been
somewhat tested now on EISA (and once more on PCI) board, and as a result of
testing another one, EISA specific error was reported, fix for which I'm going
to publish for testing RSN.
WBR, Sergei
next prev parent reply other threads:[~2013-05-02 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 22:40 [PATCH v2] 3c59x: fix PCI resource management Sergei Shtylyov
2013-05-01 22:49 ` Sergei Shtylyov
2013-05-02 17:40 ` Sergei Shtylyov [this message]
2013-05-06 16:20 ` David Miller
2013-05-06 17:29 ` Sergei Shtylyov
2013-05-06 17:53 ` David Miller
2013-05-06 18:23 ` Sergei Shtylyov
2013-05-06 18:59 ` David Miller
2013-05-06 19:33 ` Sergei Shtylyov
2013-05-06 19:57 ` David Miller
2013-05-19 19:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5182A525.8020601@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=tedheadster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).