From: "Yoann P." <yoann.p.public@gmail.com>
To: netdev@vger.kernel.org
Cc: yoann.p.public@gmail.com
Subject: [PATCH] Fix ss Netid column and Local/Peer_Address
Date: Fri, 26 Oct 2018 22:53:32 +0200 [thread overview]
Message-ID: <5185850.l7bAsbzJZX@yo-gs> (raw)
When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged, it
can be confusing when trying to pipe into awk or column.
Details (before and after output) are available on this github issue: https://
github.com/shemminger/iproute2/issues/20
Signed-off-by: YoyPa <yoann.p.public@gmail.com>
---
misc/ss.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index c8970438..5e46cc0e 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -144,9 +144,9 @@ static struct column columns[] = {
{ ALIGN_LEFT, "State", " ", 0, 0, 0 },
{ ALIGN_LEFT, "Recv-Q", " ", 0, 0, 0 },
{ ALIGN_LEFT, "Send-Q", " ", 0, 0, 0 },
- { ALIGN_RIGHT, "Local Address:", " ", 0, 0, 0 },
+ { ALIGN_RIGHT, "Local_Address:", " ", 0, 0, 0 },
{ ALIGN_LEFT, "Port", "", 0, 0, 0 },
- { ALIGN_RIGHT, "Peer Address:", " ", 0, 0, 0 },
+ { ALIGN_RIGHT, "Peer_Address:", " ", 0, 0, 0 },
{ ALIGN_LEFT, "Port", "", 0, 0, 0 },
{ ALIGN_LEFT, "", "", 0, 0, 0 },
};
@@ -1334,7 +1334,7 @@ static void sock_state_print(struct sockstat *s)
out("`- %s", sctp_sstate_name[s->state]);
} else {
field_set(COL_NETID);
- out("%s", sock_name);
+ out("%-6s", sock_name);
field_set(COL_STATE);
out("%s", sstate_name[s->state]);
}
--
2.19.1
next reply other threads:[~2018-10-27 5:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 20:53 Yoann P. [this message]
2018-10-29 17:02 ` [PATCH] Fix ss Netid column and Local/Peer_Address Stephen Hemminger
2018-10-29 18:20 ` Stefano Brivio
2018-10-29 18:49 ` Stefano Brivio
2018-10-29 20:07 ` Yoann P.
2018-10-29 22:03 ` Stefano Brivio
2018-10-29 20:06 ` Yoann P.
2018-10-29 22:03 ` Stefano Brivio
2018-10-29 22:20 ` Yoann P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5185850.l7bAsbzJZX@yo-gs \
--to=yoann.p.public@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).