* [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:23 Jingoo Han
2013-05-07 9:02 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:23 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, Jingoo Han, Nicolas Ferre
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/cadence/at91_ether.c | 1 -
drivers/net/ethernet/cadence/macb.c | 2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
index cc9a185..3f19571 100644
--- a/drivers/net/ethernet/cadence/at91_ether.c
+++ b/drivers/net/ethernet/cadence/at91_ether.c
@@ -435,7 +435,6 @@ static int at91ether_remove(struct platform_device *pdev)
unregister_netdev(dev);
clk_disable(lp->pclk);
free_netdev(dev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 6be513d..6a7bf7d 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1635,7 +1635,6 @@ err_out_put_pclk:
err_out_free_dev:
free_netdev(dev);
err_out:
- platform_set_drvdata(pdev, NULL);
return err;
}
@@ -1661,7 +1660,6 @@ static int __exit macb_remove(struct platform_device *pdev)
clk_disable_unprepare(bp->pclk);
clk_put(bp->pclk);
free_netdev(dev);
- platform_set_drvdata(pdev, NULL);
}
return 0;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set_drvdata()
2013-05-07 4:23 [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 9:02 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2013-05-07 9:02 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David S. Miller', netdev
On 07/05/2013 06:23, Jingoo Han :
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/at91_ether.c | 1 -
> drivers/net/ethernet/cadence/macb.c | 2 --
> 2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index cc9a185..3f19571 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -435,7 +435,6 @@ static int at91ether_remove(struct platform_device *pdev)
> unregister_netdev(dev);
> clk_disable(lp->pclk);
> free_netdev(dev);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 6be513d..6a7bf7d 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1635,7 +1635,6 @@ err_out_put_pclk:
> err_out_free_dev:
> free_netdev(dev);
> err_out:
> - platform_set_drvdata(pdev, NULL);
> return err;
> }
>
> @@ -1661,7 +1660,6 @@ static int __exit macb_remove(struct platform_device *pdev)
> clk_disable_unprepare(bp->pclk);
> clk_put(bp->pclk);
> free_netdev(dev);
> - platform_set_drvdata(pdev, NULL);
> }
>
> return 0;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 4:23 [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 9:02 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).