From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register Date: Tue, 07 May 2013 18:44:32 +0400 Message-ID: <51891350.9060700@cogentembedded.com> References: <1367903291-32323-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com To: Nobuhiro Iwamatsu Return-path: Received: from mail-la0-f41.google.com ([209.85.215.41]:34186 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628Ab3EGOoe (ORCPT ); Tue, 7 May 2013 10:44:34 -0400 Received: by mail-la0-f41.google.com with SMTP id fn20so661548lab.14 for ; Tue, 07 May 2013 07:44:32 -0700 (PDT) In-Reply-To: <1367903291-32323-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. You shouldn't have posted this patch (and the subsequent series) during the merge window, as David will probably tell you. On 07-05-2013 9:08, Nobuhiro Iwamatsu wrote: > Some sh-eth devices may have two ether devices inside. You probably meant to say: "some SoCs may have two Ether devices inside". > And the function of TSU is accessed from each ether device. > In this case, sh-eth need to remap address using devm_ioremap(), > without using devm_ioremap_resource(). You could use devm_ioremap_resource() for the 1st Ether instance, and devm_ioremap() for the 2nd, couldn't you? > tsu_shared_reg of sh_eth_cpu_data is used for this control. > Signed-off-by: Nobuhiro Iwamatsu WBR, Sergei