* [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:25 Jingoo Han
2013-05-07 14:49 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:25 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, Jingoo Han, Dan Carpenter, 'Rob Herring'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 4a1f2fa..7cb148c 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1790,7 +1790,6 @@ err_io:
free_netdev(ndev);
err_alloc:
release_mem_region(res->start, resource_size(res));
- platform_set_drvdata(pdev, NULL);
return ret;
}
@@ -1813,7 +1812,6 @@ static int xgmac_remove(struct platform_device *pdev)
free_irq(ndev->irq, ndev);
free_irq(priv->pmt_irq, ndev);
- platform_set_drvdata(pdev, NULL);
unregister_netdev(ndev);
netif_napi_del(&priv->napi);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata()
2013-05-07 4:25 [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 14:49 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2013-05-07 14:49 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David S. Miller', netdev, Dan Carpenter
On 05/06/2013 11:25 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
netdev is closed during the merge window except for fixes, so you will
have to resubmit this. But when you do:
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/net/ethernet/calxeda/xgmac.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
> index 4a1f2fa..7cb148c 100644
> --- a/drivers/net/ethernet/calxeda/xgmac.c
> +++ b/drivers/net/ethernet/calxeda/xgmac.c
> @@ -1790,7 +1790,6 @@ err_io:
> free_netdev(ndev);
> err_alloc:
> release_mem_region(res->start, resource_size(res));
> - platform_set_drvdata(pdev, NULL);
> return ret;
> }
>
> @@ -1813,7 +1812,6 @@ static int xgmac_remove(struct platform_device *pdev)
> free_irq(ndev->irq, ndev);
> free_irq(priv->pmt_irq, ndev);
>
> - platform_set_drvdata(pdev, NULL);
> unregister_netdev(ndev);
> netif_napi_del(&priv->napi);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 4:25 [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 14:49 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).