From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: netdev@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com
Subject: Re: [PATCH v3 4/9] net: sh-eth: Remove duplicate sh_eth_set_duplex()
Date: Tue, 07 May 2013 18:52:22 +0400 [thread overview]
Message-ID: <51891526.4090806@cogentembedded.com> (raw)
In-Reply-To: <1367903875-32606-4-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On 07-05-2013 9:17, Nobuhiro Iwamatsu wrote:
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> V3:
> Remove sh_eth_set_duplex from SH7619, SH7710 and SH7712.
> V2:
> no change.
> drivers/net/ethernet/renesas/sh_eth.c | 57 +++------------------------------
> 1 file changed, 4 insertions(+), 53 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 334fa13..944b2df 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -341,9 +341,6 @@ static void sh_eth_select_mii(struct net_device *ndev)
> }
> #endif
>
> -/* There is CPU dependent code */
> -#if defined(CONFIG_ARCH_R8A7778) || defined(CONFIG_ARCH_R8A7779)
> -#define SH_ETH_RESET_DEFAULT 1
> static void sh_eth_set_duplex(struct net_device *ndev)
I think you need to annotate this function with __maybe_unused as
well since some SoC don't use it.
WBR, Sergei
next prev parent reply other threads:[~2013-05-07 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 5:17 [PATCH v3 1/9] net: sh-eth: Remove ifdef from definition of bit of EDSR and GECMR Nobuhiro Iwamatsu
2013-05-07 5:17 ` [PATCH v3 2/9] net: sh-eth: Add comment to bit of EDSR about SH7757 Nobuhiro Iwamatsu
2013-05-07 14:48 ` Sergei Shtylyov
2013-05-07 5:17 ` [PATCH v3 3/9] net: sh-eth: Set EDSR_ENALL instead of 0x03 is set to EDSR Nobuhiro Iwamatsu
2013-05-07 5:17 ` [PATCH v3 4/9] net: sh-eth: Remove duplicate sh_eth_set_duplex() Nobuhiro Iwamatsu
2013-05-07 14:52 ` Sergei Shtylyov [this message]
2013-05-07 5:17 ` [PATCH v3 5/9] net: sh-eth: Remove SH_ETH_HAS_TSU and use tsu of sh_eth_cpu_data instead Nobuhiro Iwamatsu
2013-05-07 14:59 ` Sergei Shtylyov
2013-05-07 5:17 ` [PATCH v3 6/9] net: sh-eth: Add CONFIG_PM to definition of dev_pm_ops Nobuhiro Iwamatsu
2013-05-07 5:17 ` [PATCH v3 7/9] net: sh-eth: Add irq configureation flags in sh_eth_cpu_data Nobuhiro Iwamatsu
2013-05-07 15:02 ` Sergei Shtylyov
2013-05-07 5:17 ` [PATCH v3 8/9] net: sh-eth: Remove ifdef for sh_eth_select_mii Nobuhiro Iwamatsu
2013-05-07 5:17 ` [PATCH v3 9/9] net: sh-eth: Rewrite sh_eth_reset function Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51891526.4090806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).