* [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:44 Jingoo Han
2013-05-07 16:22 ` Roland Stigge
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:44 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, Jingoo Han, 'Wei Yongjun', Eric Dumazet,
'Roland Stigge'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/nxp/lpc_eth.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index 55a5548..a061b93 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -1483,7 +1483,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
return 0;
err_out_unregister_netdev:
- platform_set_drvdata(pdev, NULL);
unregister_netdev(ndev);
err_out_dma_unmap:
if (!use_iram_for_net(&pldat->pdev->dev) ||
@@ -1511,7 +1510,6 @@ static int lpc_eth_drv_remove(struct platform_device *pdev)
struct netdata_local *pldat = netdev_priv(ndev);
unregister_netdev(ndev);
- platform_set_drvdata(pdev, NULL);
if (!use_iram_for_net(&pldat->pdev->dev) ||
pldat->dma_buff_size > lpc32xx_return_iram_size())
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata()
2013-05-07 4:44 [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 16:22 ` Roland Stigge
0 siblings, 0 replies; 2+ messages in thread
From: Roland Stigge @ 2013-05-07 16:22 UTC (permalink / raw)
To: Jingoo Han
Cc: 'David S. Miller', netdev, 'Wei Yongjun',
Eric Dumazet
On 05/07/2013 06:44 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index 55a5548..a061b93 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1483,7 +1483,6 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
> return 0;
>
> err_out_unregister_netdev:
> - platform_set_drvdata(pdev, NULL);
> unregister_netdev(ndev);
> err_out_dma_unmap:
> if (!use_iram_for_net(&pldat->pdev->dev) ||
> @@ -1511,7 +1510,6 @@ static int lpc_eth_drv_remove(struct platform_device *pdev)
> struct netdata_local *pldat = netdev_priv(ndev);
>
> unregister_netdev(ndev);
> - platform_set_drvdata(pdev, NULL);
>
> if (!use_iram_for_net(&pldat->pdev->dev) ||
> pldat->dma_buff_size > lpc32xx_return_iram_size())
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 4:44 [PATCH 21/36] net: ethernet: nxp: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 16:22 ` Roland Stigge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).