From: PJ Waskiewicz <peter.p.waskiewicz.jr@linux.intel.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Cong Wang <amwang@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol()
Date: Wed, 08 May 2013 00:42:49 -0700 [thread overview]
Message-ID: <518A01F9.8090403@linux.intel.com> (raw)
In-Reply-To: <1367995267-23443-1-git-send-email-pshelar@nicira.com>
On 5/7/2013 11:41 PM, Pravin B Shelar wrote:
> Rather than having logic to calculate inner protocol in every
> tunnel gso handler move it to gso code. This simplifies code.
Moving code that isn't used on a regular basis to hotpath for most
networking to simplify code isn't always a good thing.
Have you run tests on non-tunneled streams using GSO to make sure there
isn't an adverse impact to performance due to the new, untaken branch?
-PJ
next prev parent reply other threads:[~2013-05-08 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 6:41 [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol() Pravin B Shelar
2013-05-08 7:42 ` PJ Waskiewicz [this message]
2013-05-08 16:23 ` Stephen Hemminger
2013-05-08 20:15 ` David Miller
2013-05-09 2:32 ` Pravin Shelar
2013-05-09 2:43 ` David Miller
2013-05-09 2:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A01F9.8090403@linux.intel.com \
--to=peter.p.waskiewicz.jr@linux.intel.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox