From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: netdev@vger.kernel.org, amirv@mellanox.com, ronye@mellanox.com
Subject: Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF link state
Date: Wed, 08 May 2013 20:02:03 +0400 [thread overview]
Message-ID: <518A76FB.5030704@cogentembedded.com> (raw)
In-Reply-To: <1368020717-22194-2-git-send-email-ogerlitz@mellanox.com>
Hello.
On 08-05-2013 17:45, Or Gerlitz wrote:
> From: Rony Efraim <ronye@mellanox.com>
> Auto - the VF link state will reflect the PF link state
>
> Enable - VF link stat will be always up, traffic from VF to VF can
> work even if PF link is down.
>
> Disable - VF link state is down and the VF can't send/recv, e.g can be
> used to suspend the link while configuring the VF.
> Signed-off-by: Rony Efraim <ronye@mellanox.com>
[...]
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index a08bd2b..bec44a3 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1238,6 +1238,15 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr *attr)
> ivs->setting);
> break;
> }
> + case IFLA_VF_LINK_STATE: {
> + struct ifla_vf_link_state *ivl;
> + ivl = nla_data(vf);
Why not make it initializer? And empty line is needed between the
declaration and other code.
WBR, Sergei
next prev parent reply other threads:[~2013-05-08 16:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:45 [PATCH RFC 0/2] Control VF link state Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 1/2] net/core: Add netlink directives to control " Or Gerlitz
2013-05-08 16:02 ` Sergei Shtylyov [this message]
2013-06-09 9:51 ` Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 2/2] net/mlx4: Add vf link state support Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC iproute2] Add VF link state control Or Gerlitz
2013-05-08 16:17 ` Stephen Hemminger
2013-05-08 16:24 ` Dan Williams
2013-05-08 16:44 ` John Fastabend
2013-05-08 17:31 ` Or Gerlitz
2013-05-09 8:34 ` Or Gerlitz
2013-05-09 15:24 ` [PATCH RFC 0/2] Control VF link state Ben Hutchings
2013-05-09 23:17 ` Or Gerlitz
2013-05-10 0:34 ` Ben Hutchings
2013-05-12 21:48 ` Or Gerlitz
2013-05-14 17:12 ` Ben Hutchings
2013-05-14 19:59 ` John Fastabend
2013-05-20 20:06 ` Or Gerlitz
2013-05-20 20:37 ` Ben Hutchings
2013-05-21 20:12 ` Or Gerlitz
2013-05-21 21:43 ` John Fastabend
2013-06-09 13:27 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A76FB.5030704@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ronye@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).