From: Daniel Borkmann <dborkman@redhat.com>
To: chetan loke <loke.chetan@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Jakub Zawadzki <darkjames-ws@darkjames.pl>
Subject: Re: [PATCH net] packet: tpacket_v3: do not trigger bug() on wrong header status
Date: Thu, 09 May 2013 20:32:52 +0200 [thread overview]
Message-ID: <518BEBD4.5020003@redhat.com> (raw)
In-Reply-To: <CAAsGZS49POkSAumqQPkVT61i3Tz7+qqiRL5C2HrUCENTW5xw+Q@mail.gmail.com>
On 05/09/2013 08:11 PM, chetan loke wrote:
> On Wed, May 8, 2013 at 8:51 PM, Daniel Borkmann <dborkman@redhat.com> wrote:
[..]
> Normally people(sane code) will look for the return value from a
> syscall. mmap is special because there's no syscall to run once you
> mmap/setup the rings. Since there's no syscall there's no return
> value. That's why we try to detect it at run-time and try to WARN the
> user if we can.
Well, I'm aware of all the internals and the problem statement. No need
for further explanations.
I also don't want to have endless, tiring discussions on netdev about a
WARN_ON_ONCE statement either.
I still don't like it for the reasons I stated ;-) but if you want to send
a patch, I'm not going to stand in the way.
prev parent reply other threads:[~2013-05-09 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 12:57 [PATCH net] packet: tpacket_v3: do not trigger bug() on wrong header status Daniel Borkmann
2013-05-03 20:12 ` David Miller
2013-05-07 16:59 ` chetan loke
2013-05-07 20:49 ` Daniel Borkmann
2013-05-07 21:56 ` Eric Dumazet
2013-05-07 21:58 ` David Miller
2013-05-08 20:32 ` chetan loke
2013-05-09 0:51 ` Daniel Borkmann
2013-05-09 18:11 ` chetan loke
2013-05-09 18:32 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BEBD4.5020003@redhat.com \
--to=dborkman@redhat.com \
--cc=darkjames-ws@darkjames.pl \
--cc=davem@davemloft.net \
--cc=loke.chetan@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).