From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Simon Horman <horms+renesas@verge.net.au>,
netdev <netdev@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [RFC PATCH net-next] sh_eth: add support for r8a7790 SoC
Date: Fri, 10 May 2013 15:10:55 +0400 [thread overview]
Message-ID: <518CD5BF.9030306@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoQXnxOncf-_JPsVP0MZLTGorywfoJu6Gx9R=TMJYoS3Bw@mail.gmail.com>
Hello.
On 10-05-2013 12:35, Magnus Damm wrote:
>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> ---
>> drivers/net/ethernet/renesas/Kconfig | 2 +-
>> drivers/net/ethernet/renesas/sh_eth.c | 10 ++++++++--
>> drivers/net/ethernet/renesas/sh_eth.h | 1 +
>> 3 files changed, 10 insertions(+), 3 deletions(-)
> Thanks for your work on this driver.
>> diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig
>> index bed9841..d664c0f 100644
>> --- a/drivers/net/ethernet/renesas/Kconfig
>> +++ b/drivers/net/ethernet/renesas/Kconfig
>> @@ -9,7 +9,7 @@ config SH_ETH
>> CPU_SUBTYPE_SH7763 || CPU_SUBTYPE_SH7619 || \
>> CPU_SUBTYPE_SH7724 || CPU_SUBTYPE_SH7734 || \
>> CPU_SUBTYPE_SH7757 || ARCH_R8A7740 || \
>> - ARCH_R8A7778 || ARCH_R8A7779)
>> + ARCH_R8A7778 || ARCH_R8A7779 || ARCH_R8A7790)
> As much as I want to see R8A7790 support right away, wouldn't it be
> nice _not_ to have this dependency crap in the Kconfig? We are already
> multi-SoC within mach-shmobile ARM and soon we will be multi-subarch.
> I actually thought that this was already taken care of. What is your
> opinion? Perhaps there are already queued up cleanup patches that
> handle this?
No, AFAIK. I haven't gotten around to the big cleanups yet.
> Thanks,
> / magnus
WBR, Sergei
next prev parent reply other threads:[~2013-05-10 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 8:01 [RFC PATCH net-next] sh_eth: add support for r8a7790 SoC Simon Horman
2013-05-10 8:35 ` Magnus Damm
2013-05-10 11:10 ` Sergei Shtylyov [this message]
2013-05-13 0:37 ` Simon Horman
2013-05-14 15:45 ` Laurent Pinchart
2013-05-10 11:00 ` Sergei Shtylyov
2013-05-13 0:36 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518CD5BF.9030306@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).