netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: "Ricardo Tubío" <rtpardavila@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Single socket with TX_RING and RX_RING
Date: Wed, 15 May 2013 16:52:24 +0200	[thread overview]
Message-ID: <5193A128.8030204@redhat.com> (raw)
In-Reply-To: <5193A00E.2020507@redhat.com>

On 05/15/2013 04:47 PM, Daniel Borkmann wrote:
> On 05/15/2013 03:32 PM, Ricardo Tubío wrote:
>> Daniel Borkmann <dborkman <at> redhat.com> writes:
>>> On 05/15/2013 02:53 PM, Ricardo Tubío wrote:
>>>> Once I tell kernel to export the TX_RING through setsockopt() (see code
>>>> below) I always get an error (EBUSY) if i try to tell kernel to export the
>>>> RX_RING with the same socket descriptor. Therefore, I have to open an
>>>> additional socket for the RX_RING and I require of two sockets when I though
>>>> that I would only require of one socket for both TX and RX using mmap()ed
>>>> memory.
>>>>
>>>> Do I need both sockets or am I doing something wrong?
>>>
>>> The second time you call init_ring() in your code e.g. with TX_RING, where
>>> you have previously set it up for the RX_RING. The kernel will give you
>>> -EBUSY because the packet socket is already mmap(2)'ed.
>
> (if you need an answer, then please do not drop the CC, otherwise it could be
>   that I might not read it)
>
>> Ok, so if I make the following system calls:
>>
>> void *ring=NULL;
>> setsockopt(socket_fd, SOL_PACKET, PACKET_RX_RING, p, LEN__TPACKET_REQ);
>> ring = mmap(NULL, ring_len, ring_access_flags, MAP_SHARED, socket_fd, 0);
>>
>> Would I be permitted to use the ring map obtained both for RX and for TX? If
>> so, for me it is confusing to use PACKET_RX_RING if I can also TX data
>> through that ring...

No, just as a side note, I think here you rather wanted to say ...

  setsockopt(socket, SOL_PACKET, PACKET_RX_RING, ...);
  setsockopt(socket, SOL_PACKET, PACKET_TX_RING, ...);

... and then only once:

  ring = mmap(NULL, ..., socket, 0);

> I haven't tried it out yet, and currently also do not really have time to. But
> looking at the mmap code, it seems that the size of the mmap area is accumulated
> for rx and tx ring. However, the header status bits are not really interoperable
> with each other. So looks you will need to have two sockets ...

  reply	other threads:[~2013-05-15 14:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 12:53 Single socket with TX_RING and RX_RING Ricardo Tubío
2013-05-15 13:20 ` Daniel Borkmann
2013-05-15 13:32   ` Ricardo Tubío
2013-05-15 14:47     ` Daniel Borkmann
2013-05-15 14:52       ` Daniel Borkmann [this message]
2013-05-15 14:58         ` Ricardo Tubío
2013-05-15 15:04           ` Daniel Borkmann
2013-05-20 20:50     ` Paul Chavent
2013-05-15 22:44 ` Phil Sutter
2013-05-16  9:18   ` Ricardo Tubío
2013-05-16 10:45     ` Phil Sutter
2013-05-16 11:01       ` Ricardo Tubío
2013-05-16 11:14         ` Daniel Borkmann
2013-05-16 11:52         ` Phil Sutter
2013-05-20 20:54         ` Paul Chavent
2013-05-22 19:36           ` Ricardo Tubío

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193A128.8030204@redhat.com \
    --to=dborkman@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rtpardavila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).