From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support Date: Thu, 14 Jul 2016 17:15:34 +0200 Message-ID: <5196839.injvYWfuBk@wuerfel> References: <1468506583-27299-1-git-send-email-p.zabel@pengutronix.de> <7346758.UKW3x0KYDY@wuerfel> <20160714151506.GI6667@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Philipp Zabel , netdev@vger.kernel.org, Rob Herring , Mark Rutland , Florian Fainelli , devicetree@vger.kernel.org, Sergei Shtylyov , Geert Uytterhoeven To: Andrew Lunn Return-path: Received: from mout.kundenserver.de ([212.227.126.130]:57893 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcGNPQA (ORCPT ); Thu, 14 Jul 2016 11:16:00 -0400 In-Reply-To: <20160714151506.GI6667@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Thursday, July 14, 2016 5:15:06 PM CEST Andrew Lunn wrote: > On Thu, Jul 14, 2016 at 04:33:26PM +0200, Arnd Bergmann wrote: > > On Thursday, July 14, 2016 4:29:43 PM CEST Philipp Zabel wrote: > > > + > > > + - micrel,fiber-mode: If present the PHY is configured to operate in fiber mode > > > + > > > + Some PHYs, such as the KSZ8041FTL variant, support fiber mode, enabled > > > + by the FXEN boot strapping pin. It can't be determined from the PHY > > > + registers whether the PHY is in fiber mode, so this boolean device tree > > > + property can be used to describe it. > > > + > > > + In fiber mode, auto-negotiation is disabled and the PHY can only work in > > > + 100base-fx (full and half duplex) modes. > > > > > > > Could the generic "phy-mode" property used for this, to avoid the need for > > definingn a custom property? > > Hi Arnd > > phy-mode is about the link between the MAC and the PHY. This property > is about the link between the PHY and its peer PHY. > Ok, got it. Arnd