From: govind <govindarajulu90@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps map is set
Date: Sat, 18 May 2013 10:48:23 +0530 [thread overview]
Message-ID: <51970F1F.5070101@gmail.com> (raw)
In-Reply-To: <1368828197.3301.112.camel@edumazet-glaptop>
>On 05/18/2013 03:33 AM, Eric Dumazet wrote:
> On Sat, 2013-05-18 at 01:20 +0530, govind wrote:
>
>> I see. In ixgbe_select_queue we use __netdev_pick_tx only if packet is not
>> FCOE & FIP.
>>
>> If you see
>> bnx2x_select_queue in drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c, line 1832
>> and mlx4_en_select_queue in drivers/net/ethernet/mellanox/mlx4/en_tx.c, line 547.
>> we cannot have xps working with these drivers.
>>
>> This needs to be fixed by replacing __skb_tx_hash with __netdev_pick_tx. Am i
>> correct?
>
> Yes, this seems better.
thanks eric, i will send patch soon.
//govind
prev parent reply other threads:[~2013-05-18 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 8:48 [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps map is set govindarajulu.v
2013-05-17 13:35 ` Eric Dumazet
2013-05-17 19:50 ` govind
2013-05-17 22:03 ` Eric Dumazet
2013-05-18 5:18 ` govind [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51970F1F.5070101@gmail.com \
--to=govindarajulu90@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).