[PATCH] net/can/mcp251x: Use module_spi_driver to register driver

[PATCH] net/can/mcp251x: Use module_spi_driver to register driver

[Peter Huewe]

Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 drivers/net/can/mcp251x.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
index f32b9fc..7a42e0f 100644
--- a/drivers/net/can/mcp251x.c
+++ b/drivers/net/can/mcp251x.c
@@ -1218,19 +1218,7 @@ static struct spi_driver mcp251x_can_driver = {
 	.resume = mcp251x_can_resume,
 };
 
-static int __init mcp251x_can_init(void)
-{
-	return spi_register_driver(&mcp251x_can_driver);
-}
-
-static void __exit mcp251x_can_exit(void)
-{
-	spi_unregister_driver(&mcp251x_can_driver);
-}
-
-module_init(mcp251x_can_init);
-module_exit(mcp251x_can_exit);
-
+module_spi_driver(mcp251x_can_driver);
 MODULE_AUTHOR("Chris Elston <celston@katalix.com>, "
 	      "Christian Pellegrin <chripell@evolware.org>");
 MODULE_DESCRIPTION("Microchip 251x CAN driver");
-- 
1.8.1.5

Re: [PATCH] net/can/mcp251x: Use module_spi_driver to register driver

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On 05/20/2013 09:49 PM, Peter Huewe wrote:
> Removing some boilerplate by using module_spi_driver instead of calling
> register and unregister in the otherwise empty init/exit functions
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

A similar patch [1] by Lars-Peter Clausen hit mainline in v3.10-rc1.

thanks, Marc

[1] 01b8807 can: mcp251x: Use module_spi_driver

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: [PATCH] net/can/mcp251x: Use module_spi_driver to register driver

[Peter Hüwe]

Am Montag, 20. Mai 2013, 21:53:31 schrieb Marc Kleine-Budde:
> On 05/20/2013 09:49 PM, Peter Huewe wrote:
> > Removing some boilerplate by using module_spi_driver instead of calling
> > register and unregister in the otherwise empty init/exit functions
> > 
> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> 
> A similar patch [1] by Lars-Peter Clausen hit mainline in v3.10-rc1.
> 
> thanks, Marc
> 
> [1] 01b8807 can: mcp251x: Use module_spi_driver


Thanks for noticing!
I was unfortunately working on a stale tree - sorry for the noise.

Thanks,
Peter