From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eliezer Tamir Subject: Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling Date: Tue, 21 May 2013 22:25:43 +0300 Message-ID: <519BCA37.4020707@linux.intel.com> References: <20130520101552.14133.45953.stgit@ladj378.jer.intel.com> <20130520101601.14133.874.stgit@ladj378.jer.intel.com> <1369063764.3301.182.camel@edumazet-glaptop> <519B2237.20204@linux.intel.com> <1369142926.3301.213.camel@edumazet-glaptop> <1369158499.3301.236.camel@edumazet-glaptop> <1369158686.3301.237.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Willem de Bruijn , e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, HPA , Jesse Brandeburg , linux-kernel@vger.kernel.org, Andi Kleen , Eliezer Tamir , Dave Miller , Pekka Riikonen To: Eric Dumazet Return-path: In-Reply-To: <1369158686.3301.237.camel@edumazet-glaptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On 21/05/2013 20:51, Eric Dumazet wrote: > On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote: > >> We do not keep skb->dev information once a packet leaves the rcu >> protected region. >> >> Once packet is queued to tcp input queues, skb->dev is NULL. > > This is done in tcp_v4_rcv() & tcp_v6_rcv() So if we move calling sk_mark_ll() into the rcu protected region, We would not need the gen id in the skb. We could save skb->dev and skb->queue_mapping along with the generation id in the socket. then we don't need to change the skb struct at all. skb_mark_ll() can go away. we also call sk_mark_ll in one central place in net_protocol->handler instead of all over the place. or am I missing something? ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired