From: John Fastabend <john.r.fastabend@intel.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>,
Or Gerlitz <ogerlitz@mellanox.com>,
netdev@vger.kernel.org, amirv@mellanox.com, ronye@mellanox.com
Subject: Re: [PATCH RFC 0/2] Control VF link state
Date: Tue, 21 May 2013 14:43:07 -0700 [thread overview]
Message-ID: <519BEA6B.4080600@intel.com> (raw)
In-Reply-To: <CAJZOPZJpPjqxX__+P0eN=XatC8pzY7zJZBQcc3U6tjQycdKB5g@mail.gmail.com>
[...]
>> The risk I see with extensible operations (and which has occurred with
>> many ethtool operations) is that drivers may quietly ignore the elements
>> they don't implement. So either (1) add yet another specific operation
>> or (2) define a general VF setter, require drivers to set some flags
>> that indicate which VF attributes are settable, and check the flags in
>> rtnetlink.c before calling into the driver.
>
> both (1) and (2) makes sense to me, I am more leaned to (2), John, do
> we have a go from your side to post V1 for net-next? which of the
> options makes more sense to you?
>
> Or.
>
Either is fine if you prefer (2) that works for me. I'll get it
working with ixgbe after you post it.
.John
next prev parent reply other threads:[~2013-05-21 21:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:45 [PATCH RFC 0/2] Control VF link state Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 1/2] net/core: Add netlink directives to control " Or Gerlitz
2013-05-08 16:02 ` Sergei Shtylyov
2013-06-09 9:51 ` Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC 2/2] net/mlx4: Add vf link state support Or Gerlitz
2013-05-08 13:45 ` [PATCH RFC iproute2] Add VF link state control Or Gerlitz
2013-05-08 16:17 ` Stephen Hemminger
2013-05-08 16:24 ` Dan Williams
2013-05-08 16:44 ` John Fastabend
2013-05-08 17:31 ` Or Gerlitz
2013-05-09 8:34 ` Or Gerlitz
2013-05-09 15:24 ` [PATCH RFC 0/2] Control VF link state Ben Hutchings
2013-05-09 23:17 ` Or Gerlitz
2013-05-10 0:34 ` Ben Hutchings
2013-05-12 21:48 ` Or Gerlitz
2013-05-14 17:12 ` Ben Hutchings
2013-05-14 19:59 ` John Fastabend
2013-05-20 20:06 ` Or Gerlitz
2013-05-20 20:37 ` Ben Hutchings
2013-05-21 20:12 ` Or Gerlitz
2013-05-21 21:43 ` John Fastabend [this message]
2013-06-09 13:27 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519BEA6B.4080600@intel.com \
--to=john.r.fastabend@intel.com \
--cc=amirv@mellanox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=ronye@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).