From: Libo Chen <clbchenlibo.chen@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Libo Chen <libo.chen@huawei.com>,
<thomas.petazzoni@free-electrons.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lizefan@huawei.com>
Subject: Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne
Date: Wed, 22 May 2013 09:06:45 +0800 [thread overview]
Message-ID: <519C1A25.8020107@huawei.com> (raw)
In-Reply-To: <519B728F.2000905@cogentembedded.com>
On 2013/5/21 21:11, Sergei Shtylyov wrote:
> Hello.
>
> On 21-05-2013 6:42, Libo Chen wrote:
>
>> set the owner of platform_driver, to ensure that the
>> caller of driver holds a module refernece
>
>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
>> ---
>> drivers/net/ethernet/marvell/mvneta.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
>> index c966785..be35a3e 100644
>> --- a/drivers/net/ethernet/marvell/mvneta.c
>> +++ b/drivers/net/ethernet/marvell/mvneta.c
>> @@ -2820,6 +2820,7 @@ static struct platform_driver mvneta_driver = {
>> .remove = mvneta_remove,
>> .driver = {
>> .name = MVNETA_DRIVER_NAME,
>> + .owner = THIS_MODULE,
>
> Indent this = with space or indent all ='s with tabs.
thanks for your suggest.
Regards,
Libo
>
>> .of_match_table = mvneta_match,
>> },
>> };
>
> WBR, Sergei
>
>
>
>
prev parent reply other threads:[~2013-05-22 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 2:42 [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne Libo Chen
2013-05-21 13:11 ` Sergei Shtylyov
2013-05-22 1:06 ` Libo Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519C1A25.8020107@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=davem@davemloft.net \
--cc=libo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).